Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift Bid Adapter: deprecate getLegacyFpd #8273

Merged
merged 12 commits into from
Apr 11, 2022
Merged

Triplelift Bid Adapter: deprecate getLegacyFpd #8273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4fc8912
Merge pull request #42 from prebid/master
Jan 6, 2022
d7e59af
Merge branch 'prebid:master' into master
nllerandi3lift Jan 14, 2022
1101d6c
Merge branch 'prebid:master' into master
nllerandi3lift Jan 31, 2022
6fff6f3
Merge branch 'prebid:master' into master
nllerandi3lift Feb 18, 2022
06a815e
Merge branch 'prebid:master' into master
nllerandi3lift Mar 7, 2022
a41b5d4
Merge branch 'prebid:master' into master
nllerandi3lift Mar 14, 2022
66ab3c8
Merge branch 'prebid:master' into master
nllerandi3lift Mar 23, 2022
7fc0801
Merge branch 'prebid:master' into master
nllerandi3lift Apr 5, 2022
905e884
deprecates getlegacyFpd
nllerandi3lift Apr 7, 2022
c2650c2
remove console log
nllerandi3lift Apr 7, 2022
9bb44c6
Merge branch 'prebid:master' into master
nllerandi3lift Apr 8, 2022
450cfb6
Merge pull request #48 from triplelift-internal/TL-26965-deprecateLeg…
nllerandi3lift Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ function _getGlobalFpd() {
const fpd = {};
const context = {}
const user = {};
const ortbData = config.getLegacyFpd(config.getConfig('ortb2')) || {};
const ortbData = config.getConfig('ortb2') || {};

const fpdContext = Object.assign({}, ortbData.context);
const fpdContext = Object.assign({}, ortbData.site);
const fpdUser = Object.assign({}, ortbData.user);

_addEntries(context, fpdContext);
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/tripleliftBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ describe('triplelift adapter', function () {
const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
const { data: payload } = request;
expect(payload.ext.fpd.user).to.not.exist;
expect(payload.ext.fpd.context.data).to.haveOwnProperty('category');
expect(payload.ext.fpd.context.ext.data).to.haveOwnProperty('category');
expect(payload.ext.fpd.context).to.haveOwnProperty('pmp_elig');
});
it('should send ad unit fpd if kvps are available', function() {
Expand Down