Count bids with function on adapter if present #773
Conversation
| }; | ||
| }; | ||
|
|
||
| function _countBids(bid) { | ||
| const bidCount = bid.sizes |
There was a problem hiding this comment.
Why do you have this unused variable?
There was a problem hiding this comment.
cruft, will remove.
| @@ -40,34 +41,41 @@ function getBidders(bid) { | |||
| return bid.bidder; | |||
| } | |||
|
|
|||
| function add(a, b) { | |||
|
|
||
| /** | ||
| * Bidders handle multiple requests and multiple sizes in different ways. | ||
| * A Bidder Adapter can export a `countBids` function if this is anything |
There was a problem hiding this comment.
should we call this "countExpectedBids" ?
|
I restarted travis and it still is failing with Seems random but maybe not... |
|
@mkendall07 review notes addressed |
| * Returns the adaptermanager.bidderRegistry | ||
| * @returns {*} | ||
| */ | ||
| $$PREBID_GLOBAL$$.getBidderRegistry = function() { |
There was a problem hiding this comment.
Why is this added to the global? We shouldn't need to expose this. If we need a means to store objects let's put it into a separate file that does not have global access.
|
The current IX adapter bid count workaround, while inelegant, is working. I've put this is on hold for the time being. We should determine the best way to either support custom bid counting or conforming to a standard way of doing this. cc: @prebid/indexexchange @indexexchange |
|
Stale PR, closing, if there is further interest here please reopen. |
Type of change
Description of change
We count bids expected so we know when to invoke callbacks for a placement and for the overall request. To support counting bids in different ways this PR will use a function
countBids, if available, in place of the default behavior.