-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp integration #756
amp integration #756
Conversation
<title>Hello, AMPs</title> | ||
<link rel="canonical" href="http://example.ampproject.org/article-metadata.html" /> | ||
<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"> | ||
<meta name="amp-3p-iframe-src" content="https://amp.prebidapp.com:5000/remote.html"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the publisher hosted content obvious with a macro or something.
document.write('<script'+' src="'+encodeURI(u)+'"><'+'/script>'); | ||
})(); | ||
</script> | ||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a <!-- start Prebid.js AMP integration -->
comment
|
||
setTimeout(function() { | ||
return initAdserver; | ||
}(), PREBID_TIMEOUT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this timeout ?
|
||
|
||
pbjs.que.push(function () { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra line breaks / spacing.
(function () { | ||
var d = document, pbs = d.createElement("script"), pro = d.location.protocal; | ||
pbs.type = "text/javascript"; | ||
pbs.src = 'https://localhost:9999/build/dev/prebid.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we load this in the head?
loadPrebidJS(); | ||
} | ||
window.context.master.adCalls.push(setTargeting.bind(null, config, done)); | ||
}, ['doubleclick'], ['prebidapp.com']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the meaning prebidapp.com
here?
|
||
pbjs.logging = true; | ||
|
||
var adUnits = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we clean this up a little bit so all publisher defined variables are declared in one spot and that's the only code that has to change on the page?
@mkendall07 notes addressed |
…ebid-0.14.0 to release/1.7.0 * commit '3eefcf043466f5457c81bfec18b032b53490b78b': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
…7.0 to master * commit '262f371a5c855419c3ef357fb1f0cf87a107749f': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
Type of change
Description of change
An example of integrating Prebid.js into an AMP page to fill
<amp-ad>
components with Prebid demand.