Implementing #697 - Custom CPM bucket sizes and precision #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve conflict Fix typo. Added `custom` price on bid object and set it automatically when using a custom config. Docs Remove trailing comma Remove the need for `bucket.cap`. Automatically finds the highest `max` value to use for the cap.
|
@matthewlane |
matthewlane
approved these changes
Oct 25, 2016
| }; | ||
|
|
||
| function getPriceBucketString(cpm, customConfig) { | ||
| var cpmFloat = 0; |
There was a problem hiding this comment.
Might want a let here for consistency
| return (Math.floor(cpm * bucketSize) / bucketSize).toFixed(precision); | ||
| } | ||
|
|
||
| export {getPriceBucketString, isValidePriceConfig }; |
There was a problem hiding this comment.
Nitpick: inconsistent spacing inside braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Implements #697 - see ticket for details.
Other information
@prebid/core team for review.
Note:
fixtures/cpmInputsOutputs.jsonwas generated from the oldbidmanager.getPriceBucketStringfunction, to ensure no breaking changes during refactor.