Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBjs Core Ajax: if xfr.open() explodes it lets the caller know #7161

Merged
merged 1 commit into from
Jul 27, 2021
Merged

PBjs Core Ajax: if xfr.open() explodes it lets the caller know #7161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export function ajaxBuilder(timeout = 3000, {request, done} = {}) {
}

x.open(method, url, true);
// IE needs timoeut to be set after open - see #1410
// IE needs timeout to be set after open - see #1410
// Disabled timeout temporarily to avoid xhr failed requests. https://github.com/prebid/Prebid.js/issues/2648
if (!config.getConfig('disableAjaxTimeout')) {
x.timeout = timeout;
Expand Down Expand Up @@ -94,6 +94,7 @@ export function ajaxBuilder(timeout = 3000, {request, done} = {}) {
}
} catch (error) {
utils.logError('xhr construction', error);
typeof callback === 'object' && callback !== null && callback.error(error);
osazos marked this conversation as resolved.
Show resolved Hide resolved
}
}
}