Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring that ref parameter is always set to correct value in sonobi … #712

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Ensuring that ref parameter is always set to correct value in sonobi … #712

merged 1 commit into from
Oct 18, 2016

Conversation

edahood-sonobi
Copy link
Contributor

@edahood-sonobi edahood-sonobi commented Oct 17, 2016 •
edited
Loading

Type of change

  • Bugfix

Description of change

Ensuring the sonobi request url includes a ref parameter only when needed

  • contact email of the adapter’s maintainer
  • official adapter submission

Other information

@protonate protonate self-assigned this Oct 18, 2016
@protonate
Copy link
Collaborator

Thanks for the PR, assigned for review.

protonate
protonate approved these changes Oct 18, 2016
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@protonate protonate merged commit d6adf1e into prebid:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protonate protonate protonate approved these changes

Assignees

@protonate protonate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edahood-sonobi @protonate