Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBS Bid Adapter: No longer pass test=1 on debug mode #6924

Merged
merged 2 commits into from
Jun 8, 2021
Merged

PBS Bid Adapter: No longer pass test=1 on debug mode #6924

merged 2 commits into from
Jun 8, 2021

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Solution to #5986

@patmmccann patmmccann requested a review from bretg June 2, 2021 17:26
@patmmccann patmmccann requested a review from idettman June 2, 2021 17:26
@ChrisHuie ChrisHuie self-assigned this Jun 7, 2021
@patmmccann patmmccann requested review from mmoschovas, harpere and a user June 8, 2021 12:18
mmoschovas
mmoschovas approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@mmoschovas mmoschovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie self-requested a review June 8, 2021 18:59
@ChrisHuie ChrisHuie merged commit c8058a6 into prebid-5.0 Jun 8, 2021
@ChrisHuie ChrisHuie deleted the 5986-pbs-test-flag branch June 8, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

@mmoschovas mmoschovas mmoschovas approved these changes

@bretg bretg Awaiting requested review from bretg

@idettman idettman Awaiting requested review from idettman

@harpere harpere Awaiting requested review from harpere

Assignees

@ChrisHuie ChrisHuie

Labels
maintenance major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patmmccann @ChrisHuie @mmoschovas