find the ad with an rtb property #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkendall07 for review |
mkendall07
approved these changes
Oct 5, 2016
| @@ -84,8 +84,9 @@ function AppnexusAstAdapter() { | |||
| } | |||
|
|
|||
| parsed.tags.forEach(tag => { | |||
| const cpm = tag.ads && tag.ads[0].cpm; | |||
| const type = tag.ads && tag.ads[0].ad_type; | |||
| const ad = tag && tag.ads && tag.ads.length && tag.ads.find(ad => ad.rtb); | |||
There was a problem hiding this comment.
nit: can make this a function and reuse on line 167
There was a problem hiding this comment.
@mkendall07 ok fixed
protonate
force-pushed
the
bugfix/appnexusAst-use-rtb-bid
branch
from
a6a176d
to
e25565a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change