Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #642 - stubbingadLoader to resolve script error build failure #678

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Address #642 - stubbingadLoader to resolve script error build failure #678

merged 1 commit into from
Oct 5, 2016

Conversation

mkendall07
Copy link
Member

Type of change

  • Bugfix

Description of change

Change spy to stub on unit tests needed to spy on adLoader.

Other information

@prebid/core for review

@mkendall07
Address #642 - adLoader was not being stubbed, thus resulting in re…
384ed27 
…questing resources that are not always script responses. This should resolve `script error` type build failures
@mkendall07
Copy link
Member Author

resolves #642 ?

protonate
protonate approved these changes Oct 4, 2016
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed to resolve the test errors, tests are green. Reviewed.

I approve this message PR.

@mkendall07 mkendall07 merged commit b385300 into master Oct 5, 2016
@mkendall07 mkendall07 deleted the bugfix/stub_adLoader branch October 5, 2016 14:22
@idettman idettman mentioned this pull request Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protonate protonate protonate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkendall07 @protonate