Allow rubicon adapter to register individual responses from fastlane … #676
Conversation
|
@snapwich Thanks for the PR. Tests look good and I'm still getting bids with the refactored changes. On a test page dev console I'm seeing |
snapwich
force-pushed
the
rubicon-events-responses
branch
from
9863dec
to
a27a78c
Compare
|
@matthewlane yes it was, good catch. I just swapped two lines, the integration needed to be set to "pbjs" before adding a listener for "FL_TIER_MAPPED" in fastlane as there is a special exception for prebid to listen to that event, otherwise it falls back to the standard non-individual response handler. Should be good now. |
| expect(bids[0].width).to.equal(300); | ||
| expect(bids[0].height).to.equal(250); | ||
| expect(bids[0].cpm).to.equal(0.811); | ||
| debugger; |
There was a problem hiding this comment.
Missed this line but discovered it in Karma debug mode. I needed to remove it so the debugger isn't invoked for others doing testing, just updated master with that change
Type of change
Description of change
The rubicon adapter was registering bids with Prebid.js after all responses were back. Now it registers the responses as they come in individually using a new event within our Fastlane code.