Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIRO Media adapter #660

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Conversation

ronenst
Copy link
Contributor

@ronenst ronenst commented Sep 28, 2016

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

New adapter and unit tests for HIRO Media

  • test parameters for validating bids

By default only 300x250 will have bid requests sent

{
  bidder: 'hiromedia',
  params: {
    accountId: 'test'
  }
}

@jaiminpanchal27
Copy link
Collaborator

Looks good. Thanks @ronenst

@jaiminpanchal27 jaiminpanchal27 merged commit 5980b8d into prebid:master Oct 7, 2016
@mkendall07
Copy link
Member

thanks @ronenst for the contribution. Can you please submit a PR here https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders to add your adapter settings to documentation? THanks

@ronenst
Copy link
Contributor Author

ronenst commented Oct 7, 2016

Thank you for the review and merge!

We'll submit a PR for the documentation.

@ronenst ronenst deleted the hiromedia-adapter branch November 8, 2016 13:14
@ronenst ronenst restored the hiromedia-adapter branch April 6, 2017 08:44
@ronenst ronenst deleted the hiromedia-adapter branch April 6, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants