Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merkle User ID Module: updates to user id submodule #6503

Merged
merged 3 commits into from
Apr 3, 2021
Merged

Merkle User ID Module: updates to user id submodule #6503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a45a241
Updating merkle user id module
Mar 30, 2021
f9e28e2
Updating merkle user id module
Mar 30, 2021
a4a7d9d
Updating merkle user id module
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updating merkle user id module
  • Loading branch information
skocheri committed Mar 31, 2021
commit a4a7d9d1d0ad10faa4d1d5dbd8e585ed510e4e86
3 changes: 1 addition & 2 deletions integrationExamples/gpt/userId_example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@
vendor:'sdfg',
sv_cid:'dfg',
sv_pubid:'xcv',
sv_domain:'zxv',
endpoint:'http://127.0.0.1/m1'
sv_domain:'zxv'
}
,
storage: {
Expand Down
10 changes: 3 additions & 7 deletions modules/merkleIdSystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { getStorageManager } from '../src/storageManager.js';

const MODULE_NAME = 'merkleId';
const SESSION_COOKIE_NAME = '_svsid';
const ID_URL = 'https://id2.sv.rkdms.com/identity/';

export const storage = getStorageManager();

Expand All @@ -35,9 +36,9 @@ function readFromLocalStorage() {

function constructUrl(configParams) {
const session = getSession(configParams);
let url = `${configParams.endpoint}?vendor=${configParams.vendor}&sv_cid=${configParams.sv_cid}&sv_domain=${configParams.sv_domain}&sv_pubid=${configParams.sv_pubid}`;
let url = ID_URL + `?vendor=${configParams.vendor}&sv_cid=${configParams.sv_cid}&sv_domain=${configParams.sv_domain}&sv_pubid=${configParams.sv_pubid}`;
if (session) {
url.append(`?sv_session=${session}`);
url.append(`&sv_session=${session}`);
}
utils.logInfo('Merkle url :' + url);
return url;
Expand Down Expand Up @@ -90,11 +91,6 @@ export const merkleIdSubmodule = {
return;
}

if (typeof configParams.endpoint !== 'string') {
utils.logError('User ID - merkleId submodule requires a valid endpoint string to be defined');
return;
}

if (consentData && typeof consentData.gdprApplies === 'boolean' && consentData.gdprApplies) {
utils.logError('User ID - merkleId submodule does not currently handle consent strings');
return;
Expand Down
6 changes: 2 additions & 4 deletions modules/userId/userId.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ pbjs.setConfig({
vendor:'sdfg',
sv_cid:'dfg',
sv_pubid:'xcv',
sv_domain:'zxv',
endpoint:'http://127.0.0.1/m1'
sv_domain:'zxv'
},
storage: {
type: "cookie",
Expand Down Expand Up @@ -185,8 +184,7 @@ pbjs.setConfig({
vendor:'sdfg',
sv_cid:'dfg',
sv_pubid:'xcv',
sv_domain:'zxv',
endpoint:'http://127.0.0.1/m1'
sv_domain:'zxv'
},
storage: {
type: "html5",
Expand Down