added timeouts to rubicon adapter that consider time-to-start costs #629
Conversation
|
@snapwich |
|
@mkendall07 well it depends on whether we want the start value to represent the time that the auction was initiated, or the time that our adapter was called. The former seems to have more value and cannot be determined from within the adapter, whereas the later can be inferred by calling In our use case we wanted to know when the auction was initiated, or more specifically, how long we had before Prebid.js' auction timeout callback would fire. Making the start time a singular value that represents the start of the auction gives us the ability to make a smart judgement call for when we should timeout inside our adapter relative to Prebid.js' auction timeout. |
snapwich
force-pushed
the
rubicon-timeout
branch
from
f2539a0 to
383afd2
Compare
|
I just noticed that start is used in the bidmanager.addBidResponse: Perhaps a new property could be added to the bidderRequest, |
|
@snapwich |
snapwich
force-pushed
the
rubicon-timeout
branch
from
383afd2 to
d25ebc7
Compare
|
updated |
|
LGTM. |
…3.0 to master * commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits) Added support for new adapters introduced in 0.13.0 into AOL analytics Updated CHANGELOG Fixed merge conflict Prebid 0.13.0 Release Resolves prebid#635 (prebid#640) Add IX Deal Support (prebid#638) Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641) added timeouts to rubicon adapter that consider time-to-start costs (prebid#629) Modify handling of no-bids in Krux Link adapter (prebid#628) Allow bypassing ajax preflights with config options (prebid#630) validateIndentation: Invalid indentation character (prebid#631) use `splice` rather than `slice` to remove bids from array (prebid#637) delete the callback before calling clearAuction (prebid#636) Deal override fix to resolve prebid#618 (prebid#619) Update package.json Video - create mastertagUrl from adservertag (prebid#614) Prevent renderAd from rendering videos (prebid#623) Remove unused build depencencies (prebid#622) Add pull request template (prebid#615) Openx adaptor deal update (prebid#612) ...
Type of change
Description of change
updated the timestamp sent to the adapters, use auction start (which I think is what start was meant to represent) instead of generating new timestamps before each call to callBids.
Also updated the rubicon adapter to use that start timestamp value to generate a relevant timeout to use for rubicon's fastlane calls.