-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichAudience Adapter: Keywords + Screen resolution + CPU Core #6204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs unit tests for the new params please.
It looks like there is also a reports JSON file getting committed in this request. Can you please take a look at that before I merge? |
@richaudience could you please remove the package-lock.json from this pr since there appears to be no change to that file. Right now it looks like all the lines in that file are being modified unless I am looking at it wrong. |
Close the pull and open other with only the necessary changes: |
Type of change
Description of change
Add new parameters to the request
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information