Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichAudience Adapter: Keywords + Screen resolution + CPU Core #6204

Closed
wants to merge 7 commits into from
Closed

RichAudience Adapter: Keywords + Screen resolution + CPU Core #6204

wants to merge 7 commits into from

Conversation

richaudience
Copy link
Contributor

Type of change

  • Bugfix
  • [ x ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add new parameters to the request

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg bretg changed the title Keywords + Screen resolution + CPU Core RichAudience Adapter: Keywords + Screen resolution + CPU Core Jan 21, 2021
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests for the new params please.

@ChrisHuie
Copy link
Collaborator

It looks like there is also a reports JSON file getting committed in this request. Can you please take a look at that before I merge?

@ChrisHuie
Copy link
Collaborator

@richaudience could you please remove the package-lock.json from this pr since there appears to be no change to that file. Right now it looks like all the lines in that file are being modified unless I am looking at it wrong.

@richaudience
Copy link
Contributor Author

richaudience commented Feb 2, 2021

Close the pull and open other with only the necessary changes:
new pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants