-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sspbc Bid Adapter: multiple updates #6118
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
59a3934
add sspbc adapter
a28b263
tests for sspbc adapter
2350cc8
sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, …
dc4d0c4
sspBC adapter v4.5: set meta.advertiserDomains, update test to expect…
7672bbc
sspBC Adapter: add ajax tests (test ad with & without gdpr)
a569a8d
sspBC Adapter: remove ajax tests
72269fd
Merge pull request #2 from prebid/master
wojciech-bialy-wpm e87dd78
Merge pull request #3 from prebid/master
wojciech-bialy-wpm 1c85801
Merge pull request #4 from prebid/master
wojciech-bialy-wpm f86b9b8
Merge pull request #5 from prebid/master
wojciech-bialy-wpm f504216
Update adapter to v4.6
wojciech-bialy-wpm bd4301a
Remove console logs for notification events
wojciech-bialy-wpm b3c7de9
Change payload data in onTimeout event
wojciech-bialy-wpm 67e2916
Merge pull request #6 from prebid/master
wojciech-bialy-wpm ca418d3
Update tests for sspBC adapter
wojciech-bialy-wpm d565abd
Merge pull request #7 from prebid/master
wojciech-bialy-wpm e440009
Update sspBC adapter to v4.7; enable oneCodeId mode; change module na…
18237ab
sspBc adapter: Bug fixes in v4.7 - change notification format, fix on…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These params should return a response from your server. I tried using these in a test page and received a
204 No Content
response.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msm0504 Could You check with the following values
{ "bidder": "sspBC", "params": { "id": "003", "siteId": "235860", "test": 1 } }
If it helps - I've updated our test pages:
https://bdr.wpcdn.pl/tests/bidderv4/test-adapter_friendly.html
https://bdr.wpcdn.pl/tests/bidderv4/test-adapter_google.html
Both are using above config, with static CMP2 module, and current version of prebid (4.20.pre) containing adapter, consent management and currency module (built using gulp build-bundle-dev --modules=sspBCBidAdapter,consentManagement,currency).
Also, please note that we've been testing 4.7 adapter on O&O inventory; as a result of that, I've pushed small fixes today (see 18237ab)