Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update teadsBidAdapter #5816

Conversation

renebaudisch
Copy link
Contributor

Type of change

  • Bugfix

Description of change

update teadsBidAdapter to return '0' instead of '' as fallback for getTimeToFirstByte method because it fails in unit tests
see #5796

…tTimeToFirstByte method because it fails in unit tests;
@Viewtiful
Copy link
Contributor

Hello @renebaudisch !
Thanks for the PR and the heads-up on a potential issue in our adapter.
After reviewing the issue and your PR, we specifically want to fallback to an empty string in case the performance APIs are not available or the time to first byte value is 0.
But we found an issue in our unit test that could cause to expect a value of 0 instead of the empty string, we have opened a PR to fix it: #5820

Best

@renebaudisch
Copy link
Contributor Author

Then the other way round, sure, I don't know your code but I'm happy if it get's fixed! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants