Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json version should match package.json #5734

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

GLStephen
Copy link
Collaborator

This drifted away for some reason, likely some quirk of update order, in a PR that added "deep-equal". 477fe0c

We should look at updating processes to require 'npm ci' unless a PR/dev is explicitly updating packages. This should improve this if not solve it. #5697 - npm previously didn't have a differentiation between install and update, it does now in the version we upgraded to recently.

This drifted away for some reason, likely some quirk of update order, in a PR that added "deep-equal". 477fe0c
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@mkendall07 mkendall07 merged commit 1e065e4 into master Sep 14, 2020
@mkendall07 mkendall07 deleted the GLStephen-patch-2 branch September 14, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants