Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds advertiserDomains to kargo adapter #5625

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Adds advertiserDomains to kargo adapter #5625

merged 2 commits into from
Aug 18, 2020

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Aug 18, 2020 •
edited
Loading

Clickurl was deprecated in #3115 in favor of advertiserDomains, an array.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Related to #4905

@patmmccann patmmccann marked this pull request as draft August 18, 2020 18:57
@patmmccann
Copy link
Collaborator Author

fyi @samuelhorwitz

@samuelhorwitz
Copy link
Contributor

Hey! Thanks for the heads up. I'm actually no longer maintaining this (although from what I can see it's likely fine), I'll CC @andyrusiecki who I believe would be maintaining things now.

@patmmccann patmmccann marked this pull request as ready for review August 18, 2020 19:44
@andyrusiecki
Copy link
Contributor

Thanks @samuelhorwitz! Everything here looks good to me

@robertrmartinez robertrmartinez merged commit fb72d51 into prebid:master Aug 18, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@patmmccann @BrightMountainMediaInc
Adds advertiserDomains to kargo adapter (prebid#5625)
ec47f4b 
* Update kargoBidAdapter.js

* Update kargoBidAdapter_spec.js
BrightMountainMediaInc added a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@BrightMountainMediaInc
Revert "Adds advertiserDomains to kargo adapter (prebid#5625)"
2a869c2 
This reverts commit ec47f4b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrusiecki andyrusiecki andyrusiecki approved these changes

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patmmccann @samuelhorwitz @andyrusiecki @robertrmartinez