module rule documentation updates #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Aug 20, 2020
There was a problem hiding this comment.
Hi @bretg
Thanks for putting this together. I think it largely looks good. I did have one question about one of the links. Please take a look when you have a minute.
Thanks.
| - Adapters may not use the $$PREBID_GLOBAL$$ variable | ||
| - All adapters must support the creation of multiple concurrent instances. This means, for example, that adapters cannot rely on mutable global variables. | ||
| - Adapters may not globally override or default the standard ad server targeting values: hb_adid, hb_bidder, hb_pb, hb_deal, or hb_size, hb_source, hb_format. | ||
| - All required global and bidder-adapter rules defined in the [Module Rules](https://docs.prebid.org/dev-docs/module-rules.html) must be followed. Please review these rules often - we depend on reviewers to enforce them. |
There was a problem hiding this comment.
The current link goes to a 404. Just to confirm - will this page exist in the near future?
There was a problem hiding this comment.
Right - was waiting on the docs PR merge until that was reviewed and we discussed in the PBJS committee yesterday the proposal that all of the aspirational rules are aimed for 5.0. Anyhow, just merged the docs PR and that URL is now available.
jsnellbaker
approved these changes
Aug 20, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* module rule updates * Adding FPD.user
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 8cac7cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Documentation update for module rules.
Please don't merge this until prebid/prebid.github.io#2242 is merged.