-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWPlayer Targeting Module #5493
Conversation
Why build a new module type instead of utilizing an rtd submodule? |
@patmmccann do you recommend making this an rtd submodule ? Why so ? The targeting info is in part historical, not always rtd |
delaying the auction for data seems like it should use the rtd module #4610 and your functionality feels like a submodule. A bunch of unicorn modules that don't fall into module types with rules described on #5239 feels like potentially an end run around the rules at worst, duplicate functionality at best. |
@omerBrowsi what are your thoughts on this |
@patmmccann thank you for your feedback. Upon review of the rtdModule I think it does make sense for the JW Player module to be a submodule. I will close this PR for now. @omerBrowsi still looking forward to any feedback you may have. |
Type of change
Description of change
Adds the
jwplayerTargeting
module which allows Ad Bidders to access JW Player's Video Ad Targeting information.The module can be used as a submodule for prebid adapters, allowing them to use our
getTargetingForBid()
function.the module will fetch segments for the media ids present in the prebid config when the module loads. If any bid requests are made while the segments are being fetched, they will be blocked until all requests complete, or the 150ms timeout expires.