Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidazoo Adapter: Feature/unique-deal-id #5488

Merged
merged 13 commits into from
Aug 6, 2020

Conversation

uditalias
Copy link
Contributor

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)

Description of change

Sends unique deal id as a server param

@uditalias
Copy link
Contributor Author

@GLStephen LMK if I can assist with the merge of this PR. Thanks.

@GLStephen
Copy link
Collaborator

@uditalias this looks good, but based on GDPR requirements you need to update your sessionStorage access to access through the utils storage class. Once that's updated I can review again. Thanks!

@GLStephen
Copy link
Collaborator

@uditalias Rule 2 here covers this in the proposed rules #5239

@uditalias
Copy link
Contributor Author

uditalias commented Jul 26, 2020

@GLStephen Thank you for your review.
Is there any way to use the sessionStorage instead of the localStorage? I found the storageManager but only the local storage is supported.
I think that the local storage is too aggressive for my feature because it will persist across site visits.

@GLStephen
Copy link
Collaborator

GLStephen commented Jul 27, 2020

@uditalias The setCookie and getCookie functions should be capable of creating session cookies. https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie

@uditalias
Copy link
Contributor Author

@GLStephen I changed the code to use the storageManager from utils. Please note that I added another field param called sessionId, this field is extracted from the localStorage (using the storageManager) and passed as a param to the server. Thanks.

@GLStephen GLStephen merged commit ea45ae6 into prebid:master Aug 6, 2020
@GLStephen
Copy link
Collaborator

@uditalias merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants