-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vidazoo Adapter: Feature/unique-deal-id #5488
Conversation
added tests
@GLStephen LMK if I can assist with the merge of this PR. Thanks. |
@uditalias this looks good, but based on GDPR requirements you need to update your sessionStorage access to access through the utils storage class. Once that's updated I can review again. Thanks! |
@uditalias Rule 2 here covers this in the proposed rules #5239 |
@GLStephen Thank you for your review. |
@uditalias The setCookie and getCookie functions should be capable of creating session cookies. https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie |
@GLStephen I changed the code to use the |
@uditalias merged |
Type of change
Description of change
Sends unique deal id as a server param