Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Districtm dmx UID support #5162

Merged
merged 41 commits into from
Apr 28, 2020
Merged

Conversation

stevealliance
Copy link
Contributor

Adding support for id5 pubCommon digitrust Trading Desk

Type of change

  • Bugfix
  • [ x] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

@smenzer
Copy link
Collaborator

smenzer commented Apr 23, 2020

You should update your bidder docs in https://github.com/prebid/prebid.github.io to mention support of the user ID modules:

userIds: digitrust, id5Id, identityLink, pubCommonId, unifiedId

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please consider adding unit tests for future PR's

@robertrmartinez robertrmartinez merged commit a88ff90 into prebid:master Apr 28, 2020
jimee02 pushed a commit to openx/Prebid.js that referenced this pull request Jun 12, 2020
* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location

* current machine state

* lint correction

* remove variable assigment duplicate

* adding CCPA support for DMX

* adding test for ccpa and gdpr

* districtm dmx adding deal id field

* idsync support ccpa & gdpr

* adding support uid provide tdid id5 pubCommon digitrust

Co-authored-by: Steve Alliance <steve@districtm.ca>
Co-authored-by: Luis <luissastreverzun@gmail.com>
Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain>
Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local>
Co-authored-by: steve-a-districtm <steve@districtm.net>
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location

* current machine state

* lint correction

* remove variable assigment duplicate

* adding CCPA support for DMX

* adding test for ccpa and gdpr

* districtm dmx adding deal id field

* idsync support ccpa & gdpr

* adding support uid provide tdid id5 pubCommon digitrust

Co-authored-by: Steve Alliance <steve@districtm.ca>
Co-authored-by: Luis <luissastreverzun@gmail.com>
Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain>
Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local>
Co-authored-by: steve-a-districtm <steve@districtm.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants