-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Districtm dmx UID support #5162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test @97%, two files added one updated
update my fork
Adding the readme.md info
Documentation updates
Update full repo
updating master
You should update your bidder docs in https://github.com/prebid/prebid.github.io to mention support of the user ID modules:
|
robertrmartinez
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please consider adding unit tests for future PR's
jimee02
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Jun 12, 2020
* adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * adding support uid provide tdid id5 pubCommon digitrust Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net>
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * adding support uid provide tdid id5 pubCommon digitrust Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
id5
pubCommon
digitrust
Trading Desk
Type of change