Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid manager analytics utm tags #4998

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Prebid manager analytics utm tags #4998

merged 4 commits into from
Apr 8, 2020

Conversation

Prebid-Manager
Copy link
Contributor

@Prebid-Manager Prebid-Manager commented Mar 18, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link

@bx2 bx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments below.

modules/prebidmanagerAnalyticsAdapter.js Outdated Show resolved Hide resolved
modules/prebidmanagerAnalyticsAdapter.js Outdated Show resolved Hide resolved
modules/prebidmanagerAnalyticsAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/prebidmanagerAnalyticsAdapter_spec.js Outdated Show resolved Hide resolved
@Prebid-Manager Prebid-Manager requested a review from bx2 April 1, 2020 16:58
@Prebid-Manager
Copy link
Contributor Author

@bx2 please see the changes based your comment. Thank you.

Copy link

@bx2 bx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bx2 bx2 merged commit c318c02 into prebid:master Apr 8, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* prebidmanager add utm tags support

* prebidmanager add utm tags support tests

* prebidmanager add utm tags support tests

* prebidmanager add utm tags support fixes

Co-authored-by: apuzanova <apuzanova@asteriosoft.com>
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 16, 2020
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* prebidmanager add utm tags support

* prebidmanager add utm tags support tests

* prebidmanager add utm tags support tests

* prebidmanager add utm tags support fixes

Co-authored-by: apuzanova <apuzanova@asteriosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants