#4904 Modify vendor gdpr check to deny consent on timeout #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… __cmp exists. Fix fallthrough error and new test for __cmp not present.
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
… __cmp exists. Fix fallthrough error and new test for __cmp not present. (prebid#4906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where __cmp exists. Fix fallthrough error and new test for __cmp not present.
Type of change
Description of change
This modifies behavior of the cmp vendor check to be more GDPR compliant in cases where cmp is discovered but fails to respond to ping request. Previously consent check passed with assumption GDPR did not apply. More conservative assumption that GDPR does apply if cmp library is found, and fails all tests except explicit consent.
Other information
Solves #4904 and fixes a fallthrough if case error.
Unit tests show new behavior.