Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4904 Modify vendor gdpr check to deny consent on timeout #4906

Merged

Conversation

goosemanjack
Copy link
Contributor

where __cmp exists. Fix fallthrough error and new test for __cmp not present.

Type of change

  • [X ] Bugfix

Description of change

This modifies behavior of the cmp vendor check to be more GDPR compliant in cases where cmp is discovered but fails to respond to ping request. Previously consent check passed with assumption GDPR did not apply. More conservative assumption that GDPR does apply if cmp library is found, and fails all tests except explicit consent.

Other information

Solves #4904 and fixes a fallthrough if case error.
Unit tests show new behavior.

… __cmp exists. Fix fallthrough error and new test for __cmp not present.
Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msm0504 msm0504 merged commit daacb10 into prebid:master Mar 5, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
… __cmp exists. Fix fallthrough error and new test for __cmp not present. (prebid#4906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants