Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bucksenseBidAdapter.js #4898

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

bkse-stefanodechicchis
Copy link
Contributor

@bkse-stefanodechicchis bkse-stefanodechicchis commented Feb 26, 2020

Removed port 445, going on default 443

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Removed port 445, going on default 443
@bkse-stefanodechicchis
Copy link
Contributor Author

Removed port 445, going on default 443

@jsnellbaker
Copy link
Collaborator

Hi @bkse-stefanodechicchis
For the sake of consistency, can you also update your unit tests to no longer include this port?

@bkse-stefanodechicchis
Copy link
Contributor Author

Done update unit test, #4912

@jsnellbaker jsnellbaker merged commit 146b7b8 into prebid:master Mar 3, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
Removed port 445, going on default 443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants