Add 1ad4good bidder

[vladgurgov]

Type of change

• [ X] New bidder adapter
  DONE: Add doc for 1ad4good.org bidder prebid.github.io#1428

Description of change

This is open source bidder for non profit ads that I created this weekend. Could be used to fill unsold inventory for a good causes.

More info about this project can be found here: http://1ad4good.org

I hope it will be net positive for this community as:

open source education about tech and header bidding
always filling (good for some test cases for ad ops
providing some free ad placements to non profits
Thank you!

• test parameters for validating bids

{
  bidder: '1ad4good',
  params: {
    placementId: 13144370
  }
}

Be sure to test the integration with your adserver using the Hello World sample page. -DONE

• contact email of the adapter’s maintainer vlad@aaaudi.com
• [ X] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[vladgurgov]

@Fawke thank you for looking into it!

It's pretty straightforward, based on appnexus bidder code(for easier adops setup) with some unused code removed. nothing special..

[Fawke]

Hey @vladgurgov,

I've been through the PR and made few observations that needs changes.

• Your Test coverage is low (77.67%) which is less than our recommended 80% coverage. You can either remove unnecessary code from your Adapter file, or, you can add more test cases to cover more statements.
• The call to your Ad Server is recommended to go over https. If your server supports it, please consider changing it over.
• The call to load Instream video ad is not returning any bids. Please find the screenshot of the response.

[vladgurgov]

Thanks for your comments @Fawke ! This was my first contribution to this project so I definitely was trying to obey all the rules.

I was developing based on appnexus adapter, so most of the code is the same.
In appnexusBidAdapter.js endpoint is
const URL = '//ib.adnxs.com/ut/v3/prebid';

in rubicon:
export const FASTLANE_ENDPOINT = '//fastlane.rubiconproject.com/a/api/fastlane.json';
export const VIDEO_ENDPOINT = '//prebid-server.rubiconproject.com/openrtb2/auction';

in mine its:
const URL = '//hb.1ad4good.org/prebid';

Should I hardcode https:// in it? I support https, i just wanted to follow the same rules.

Tests are based on appnexusBidAdapter.js which has 75.92% coverage... I will look into adding more tests

I don't bid on video yet, but i will add video campaign on server to make it bid on video as well.

Thanks for your feedback again!

[vladgurgov]

• Unused code was removed
• Test coverages is over >80% now
• Video campaign added on bidder for testing and tested for compatibility
• Still waiting if endpoint should be hardcoded to https:// instead of //

Thanks!

[vladgurgov]

@Fawke could you please take another look? Thank you!

[vladgurgov]

@mkendall07 @Fawke could you take look, thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bretg]

re-opening -- ping @Fawke

[Fawke]

@vladgurgov Sorry for the delay in response, I've suggested some changes for you. Let me know if you can incorporate that in your code.

For your question on hardcoding the endpoint to https, yes, you can do that.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[vladgurgov]

@Fawke , please take a look again. I removed most of unused code.

Our initial idea with it was that we could simply use this module to test on client side easily by renaming appnexus -> 1ad4good. So that replacing one line immediately let us get fill from us and test code. And we simply wanted to make sure everything is as close to appnexus as possible.

However, I agree with you - since we dont use most of these params it makes sense to remove it. Please take a look. Thanks!

[Fawke]

@vladgurgov

Thanks for making the required changes. There's just one last change which I suggest you make now, you can hardcode your endpoing URL to https in line:8 in 1ad4goodBidAdapter.js file.

In the next major release of Prebid, we are having all bidder adapters convert to https. Failing to do so will result in them not being included in the next major release.

[vladgurgov]

@Fawke
Makes sense. Just updated to https://
Please keep in mind that appnexus module still using //

If this is accepted I can also add some sample pages and docs. I think it could be good beginners "entry-point" for Prebid and it would allow anyone to test and experiment Prebid without any accounts on Appnexus, Rubicon, their ad servers and still get 100% fill.

Let me know if you think it makes sense of you have other ideas for contributing to this project.

Thanks!