Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sizes handling in adYouLike adaptor #4013

Merged
merged 11 commits into from
Aug 11, 2019
Merged

Conversation

guiann
Copy link
Contributor

@guiann guiann commented Jul 22, 2019

Type of change

  • Bugfix
  • [* ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add multiple sizes handling in adYouLike bidder adaptor.

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be looking in AdUnit.mediaType.sizes -- if it's not, please update to look in that location as well as AdUnit.sizes, which has been deprecated for a long time.

@bretg bretg self-assigned this Jul 22, 2019
@guiann
Copy link
Contributor Author

guiann commented Jul 25, 2019

Changes have been made regarding the use of bid.mediatype.banner.sizes

@stale
Copy link

stale bot commented Aug 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 8, 2019
@guiann
Copy link
Contributor Author

guiann commented Aug 9, 2019

Why is this Pull request in stale state ?
It is ready to be merged.
@bretg can you please have a look?

thank you.

@stale stale bot removed the stale label Aug 9, 2019
@harpere harpere merged commit 1f08933 into prebid:master Aug 11, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* Remove useless bidderCode in bid response

* send all the available sizes in the bid request

* Use the banner sizes if given

* avoid compatibility issue with old bid format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants