Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pubCommonId import from emoteevBidAdapter #3932

Closed
wants to merge 1 commit into from

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Modules should not directly import other modules as it results in accidental code inclusion or possibly duplicate code inclusion (if that module was already included). If it does in-fact depend on the other module being present you might be interested in work on submodules here: #3924

/cc @piotr-yuxuan

@snapwich
Copy link
Collaborator Author

Closed as this was cherry-picked into #3928

@snapwich snapwich closed this Jun 21, 2019
@snapwich snapwich deleted the emoteev-use-utils-getcookie branch June 21, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants