Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic: Making Adslot param optional #3788

Merged
merged 59 commits into from
May 1, 2019
Merged

Pubmatic: Making Adslot param optional #3788

merged 59 commits into from
May 1, 2019

Commits on Dec 19, 2018

  1. Merge pull request #1 from prebid/master 

    merging prebid master into fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Dec 19, 2018
    Configuration menu
    Copy the full SHA
    7a10d02 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Merge pull request #2 from prebid/master 

    merge from prebid master to fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Dec 26, 2018
    Configuration menu
    Copy the full SHA
    8082b2e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. Merge pull request prebid#3 from prebid/master 

    merge from prebid master to fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Jan 9, 2019
    Configuration menu
    Copy the full SHA
    6e856c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Merge pull request prebid#4 from prebid/master 

    merge from prebid master to fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Jan 16, 2019
    Configuration menu
    Copy the full SHA
    881c7db View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Merge pull request prebid#6 from prebid/master 

    Merge prebid master into fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5dc2d30 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Merge pull request prebid#8 from prebid/master 

    merge from prebid master
    @pm-manasi-moghe
    pm-manasi-moghe authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e3c151a View commit details
    Browse the repository at this point in the history

  2. changes for multiformat support

    @pm-manasi-moghe
    pm-manasi-moghe committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    1b7c856 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Merge pull request prebid#9 from prebid/master 

    merge latest prebid into fork master
    @pm-manasi-moghe
    pm-manasi-moghe authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    84c6e64 View commit details
    Browse the repository at this point in the history

  2. Merge pull request prebid#10 from pm-manasi-moghe/master 

    merge latest prebid from master into branch
    @pm-manasi-moghe
    pm-manasi-moghe authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    feaf0fa View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Merge pull request prebid#11 from prebid/master 

    merge prebid master into fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    7cb5041 View commit details
    Browse the repository at this point in the history

  2. Merge pull request prebid#12 from pm-manasi-moghe/master 

    merge latest prebid master into branch
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    7867370 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. added new constant NATIVE_ASSETS in PubMatic adapter

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    f8c50ec View commit details
    Browse the repository at this point in the history

  2. removed NATIVE_ASSET_KEY reference in PubMatic adapter

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    7f4cf0e View commit details
    Browse the repository at this point in the history

  3. removed reference of const NATIVE_ASSET_ID from PubMatic adapter

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c6aba1a View commit details
    Browse the repository at this point in the history

  4. removed reference of const NATIVE_ASSET_DATA_TYPE in PubMatic adapter

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    13550ea View commit details
    Browse the repository at this point in the history

  5. using _commonNativeRequestObject in PubMatic adapter to avoid repeati… 

    …ng code block
    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    bcea4d6 View commit details
    Browse the repository at this point in the history

  6. removed new-lines in const declaration

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    7404ddf View commit details
    Browse the repository at this point in the history

  7. generating NATIVE_ASSET_REVERSE_ID from NATIVE_ASSETS

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    1695fb9 View commit details
    Browse the repository at this point in the history

  8. renamed NATIVE_ASSET_REVERSE_ID to NATIVE_ASSET_ID_TO_KEY_MAP

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    d22d730 View commit details
    Browse the repository at this point in the history

  9. little modification in _checkParamDataType in PubMatic adapter

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    54580cc View commit details
    Browse the repository at this point in the history

  10. a minor improvement

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c408166 View commit details
    Browse the repository at this point in the history

  11. using let instead of var

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    09fb481 View commit details
    Browse the repository at this point in the history

  12. added NATIVE_ASSET_KEY_TO_ASSET_MAP and combining switch cases

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    688e8ff View commit details
    Browse the repository at this point in the history

  13. lint update

    @pm-harshad-mane
    pm-harshad-mane committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    cad5bed View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. removed some stale comments

    @pm-harshad-mane
    pm-harshad-mane committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    9b79c2e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Merge remote-tracking branch 'upstream/master' into native_refactor 

    updating current branch from master
    @pm-harshad-mane
    pm-harshad-mane committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    07ea62e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merge branch 'UOE4057_multiformat' of https://github.com/pm-manasi-mo… 

    …ghe/Prebid.js into pm-manasi-moghe-UOE4057_multiformat
    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    72cbae6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pm-manasi-moghe-UOE4057_multiformat' into native_refactor 

    Trying to merge Manasi's code
    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    53e1f35 View commit details
    Browse the repository at this point in the history

  3. using LOG_WARN_PREFIX

    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    2269e39 View commit details
    Browse the repository at this point in the history

  4. using const UNDEFINED

    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    83f3cb8 View commit details
    Browse the repository at this point in the history

  5. added a logWarn in catch

    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b482471 View commit details
    Browse the repository at this point in the history

  6. using arrow functions

    @pm-harshad-mane
    pm-harshad-mane committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    ddf4c66 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Merge pull request prebid#13 from prebid/master 

    merge from latest prebid master
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    6c50bd3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request prebid#14 from pm-harshad-mane/native_refactor 

    Native refactor
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c5ab18d View commit details
    Browse the repository at this point in the history

  3. code review changes

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    9ee6927 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. making adSlot parameter optional

    @pm-harshad-mane
    pm-harshad-mane committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    fde5434 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2019

  1. added a test case for without adSlot config

    @pm-harshad-mane
    pm-harshad-mane committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    5d8d590 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. changes to checkMediaType function

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    7da2a32 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Merge remote-tracking branch 'upstream/master' into native_refactor 

    updating from master
    @pm-harshad-mane
    pm-harshad-mane committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    9b75199 View commit details
    Browse the repository at this point in the history

  2. Merge pull request prebid#15 from pm-harshad-mane/native_refactor 

    Native refactor
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 26, 2019
    Configuration menu
    Copy the full SHA
    ec67b85 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. Merge pull request prebid#16 from prebid/master 

    merge prebid master to fork
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 27, 2019
    Configuration menu
    Copy the full SHA
    04ebe44 View commit details
    Browse the repository at this point in the history

  2. Merge pull request prebid#17 from pm-manasi-moghe/master 

    merge prebid master into MFR branch
    @pm-manasi-moghe
    pm-manasi-moghe authored Mar 27, 2019
    Configuration menu
    Copy the full SHA
    a583147 View commit details
    Browse the repository at this point in the history

  3. suppress warning of missing mediaTypes.banner for native and video im… 

    …pression
    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    5d83608 View commit details
    Browse the repository at this point in the history

  4. ignore fluid size, if present, in banner impression

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    67d3a7c View commit details
    Browse the repository at this point in the history

  5. fix for ignoring fluid size in banner impression

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    e985be4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. added relevant comments and test cases for fluid case in banner request

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    b2b9e2d View commit details
    Browse the repository at this point in the history

  2. added sample config for multiformat adunit

    @pm-manasi-moghe
    pm-manasi-moghe committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c715ef0 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from pm-manasi-moghe/multiformat_refactor_changes 

    Multiformat refactor changes
    @pm-harshad-mane
    pm-harshad-mane authored Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ef70966 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Merge branch 'native_refactor' into adslot_param_optional

    @pm-harshad-mane
    pm-harshad-mane committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    d5f41cc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into adslot_param_opti… 

    …onal
    @pm-harshad-mane
    pm-harshad-mane committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    6c4567c View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. commented redundant check

    @pm-harshad-mane
    pm-harshad-mane committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    eb9ae7a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Merge remote-tracking branch 'upstream/master' into adslot_param_opti… 

    …onal
    @pm-harshad-mane
    pm-harshad-mane committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    b116176 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Merge remote-tracking branch 'upstream/master' into adslot_param_opti… 

    …onal
    @pm-harshad-mane
    pm-harshad-mane committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    451d87f View commit details
    Browse the repository at this point in the history

  2. marking adSlot param as optional in examples

    @pm-harshad-mane
    pm-harshad-mane committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    f33aedf View commit details
    Browse the repository at this point in the history

  3. fixed some lint errors

    @pm-harshad-mane
    pm-harshad-mane committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    e12c1be View commit details
    Browse the repository at this point in the history

  4. removed commnented code

    @pm-harshad-mane
    pm-harshad-mane committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    76b6864 View commit details
    Browse the repository at this point in the history

  5. removed a trailing white space

    @pm-harshad-mane
    pm-harshad-mane committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    c9fae84 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. removed a todo comment as suggested in review

    @pm-harshad-mane
    pm-harshad-mane committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    5f7fb8d View commit details
    Browse the repository at this point in the history

  2. deleting commented test cases

    @pm-harshad-mane
    pm-harshad-mane committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    333a0e7 View commit details
    Browse the repository at this point in the history