-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartadserverBidAdapter.js - make bid.params.domain optional #3781
Conversation
https://prg.smartadserver.com is the standard domain for smartadserver. This update make the "bid.params.domain"-parameter optional.
I don't understand why only this one browser doesn't run this test successfully? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but please update your documentation page to reflect the optional status
external page at http://prebid.org/dev-docs/bidders.html#smartadserver
source at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/smartadserver.md
Also - re-ran the circle-ci tests and they passed this time. There are occasional glitches. |
make bid.params.domain optional prebid/Prebid.js#3781
Hi @bretg , I've changed the documentation: |
make bid.params.domain optional prebid/Prebid.js#3781
…3781) https://prg.smartadserver.com is the standard domain for smartadserver. This update make the "bid.params.domain"-parameter optional.
…3781) https://prg.smartadserver.com is the standard domain for smartadserver. This update make the "bid.params.domain"-parameter optional.
https://prg.smartadserver.com is the standard domain for smartadserver. This update makes the "bid.params.domain"-parameter optional.
Type of change
Description of change