smartadserverBidAdapter.js - make bid.params.domain optional

[phtechno]

https://prg.smartadserver.com is the standard domain for smartadserver. This update makes the "bid.params.domain"-parameter optional.

Type of change

• Code style update (formatting, local variables)

Description of change

[phtechno]

IE 11.0.0 (Windows 10.0.0): Executed 3626 of 3627 (skipped 1) SUCCESS (11.532 secs / 5.748 secs)
Chrome 72.0.3626 (Windows 10.0.0): Executed 3629 of 3630 (skipped 1) SUCCESS (8.876 secs / 3.391 secs)
Safari 12.0.0 (Mac OS X 10.14.0): Executed 3626 of 3627 (skipped 1) SUCCESS (9.065 secs / 5.272 secs)
Safari 11.1.2 (Mac OS X 10.13.6): Executed 3626 of 3627 (skipped 1) SUCCESS (9.522 secs / 5.282 secs)
Firefox 65.0.0 (Windows 10.0.0): Executed 3629 of 3630 (skipped 1) SUCCESS (10.354 secs / 4.31 secs)
Chrome 71.0.3578 (Windows 10.0.0): Executed 0 of 0 ERROR (0.039 secs / 0 secs)
Edge 16.16299.0 (Windows 10.0.0): Executed 3626 of 3627 (skipped 1) SUCCESS (11.199 secs / 5.92 secs)
Edge 17.17134.0 (Windows 10.0.0): Executed 3626 of 3627 (skipped 1) SUCCESS (9.753 secs / 4.699 secs)
Firefox 64.0.0 (Windows 10.0.0): Executed 3629 of 3630 (skipped 1) SUCCESS (10.745 secs / 4.257 secs)

I don't understand why only this one browser doesn't run this test successfully?

[bretg]

Looks fine, but please update your documentation page to reflect the optional status

external page at http://prebid.org/dev-docs/bidders.html#smartadserver
source at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/smartadserver.md

[bretg]

Also - re-ran the circle-ci tests and they passed this time. There are occasional glitches.

[phtechno]

Hi @bretg ,

I've changed the documentation:
prebid/prebid.github.io#1295