Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ref error on yieldmo adapter #3776

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

ETNOL
Copy link
Contributor

@ETNOL ETNOL commented Apr 23, 2019

Type of change

  • Bugfix

Description of change

Null checks for request.crumbs in the yieldmo bid adapter.

Other information

@HolzAndrew

@HolzAndrew
Copy link
Contributor

@ETNOL thank you! LGTM

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, there was a yarn.lock added which I deleted to save one more back and forth. LGTM now without the yarn.lock file

@idettman idettman added the LGTM label Apr 30, 2019
@idettman idettman merged commit 4155553 into prebid:master Apr 30, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* fix ref error on yieldmo adapter

* Delete yarn.lock
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* fix ref error on yieldmo adapter

* Delete yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants