Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn Analytics Adapter #3761

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Sovrn Analytics Adapter #3761

merged 3 commits into from
Apr 25, 2019

Conversation

aprakash-sovrn
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Sovrn Analytics Adapter

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aprakash-sovrn

Can you please take a look at the change request below?

Additionally, can you please put together a docs PR (here)[https://github.com/prebid/prebid.github.io/pulls] to add your analytics adapter to the list? It should be at least this page that needs an update: https://github.com/prebid/prebid.github.io/blob/master/overview/analytics.md

import CONSTANTS from 'src/constants.json'
import {ajaxBuilder} from 'src/ajax'
import * as utils from 'src/utils'
import {config} from 'src/config'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lieu of this PR #3435, any imported files within a modules file needs to use the relative style path.

Can you please update these imports accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing. does this apply to npm modules as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it should just be needed for any Prebid imports.

@aprakash-sovrn
Copy link
Contributor Author

Created doc PR: prebid/prebid.github.io#1282

@jsnellbaker jsnellbaker merged commit 2741f95 into prebid:master Apr 25, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
* Sovrn Analytics Adapter

* unit test fix

* use relative paths for imports
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Sovrn Analytics Adapter

* unit test fix

* use relative paths for imports
@s-nikulin-lineate s-nikulin-lineate deleted the sovrn-analytics branch June 20, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants