Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgidAdapter #3562

Merged
merged 16 commits into from
Feb 22, 2019
Merged

mgidAdapter #3562

merged 16 commits into from
Feb 22, 2019

Conversation

Gaudeamus
Copy link
Contributor

@Gaudeamus Gaudeamus commented Feb 15, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids

300x600 banner test

var adUnits = [{
  code: 'div-prebid',
  mediaTypes: {
    banner: {
      sizes: [[300, 600]]
    }
  },
  // Replace this object to test a new Adapter!
  bids: [{
    bidder: 'mgid',
    params : {
      accountId : "219", //test accountId, please replace after test
      placementId : "331749" // 300x600 test placementId, please replace after test
    }
  }]
}];

300x250 banner test

var adUnits = [{
  code: 'div-prebid',
  mediaTypes: {
    banner: {
      sizes: [[300, 250]]
    }
  },
  // Replace this object to test a new Adapter!
  bids: [{
    bidder: 'mgid',
    params : {
      accountId : "219", //test accountId, please replace after test
      placementId : "331748" // 300x250 test placementId, please replace after test
    }
  }]
}];

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    prebid@mgid.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@Gaudeamus
Copy link
Contributor Author

mgid adapter added

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 19eea57 into 9b08b15 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@Gaudeamus
Copy link
Contributor Author

huh

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, the only issue is the comment I posted.

const returnedBids = [];
const muidn = utils.deepAccess(serverResponse.body, 'ext.muidn')
if (muidn != null && typeof (muidn) == 'string' && muidn.length > 0) {
setLocalStorageSafely('mgMuidn', muidn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure, but is this adapter only going to be used in non-GDPR environments? Otherwise, to save user data locally, the consentManagement module needs to be checked for consentString and the vendors list for consent to save data locally. If this isn't going to be used in a GDPR environment, this should be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added support of gdpr. we'll not return ext.muidn if tracking is not allowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idettman added test params to docs

@Gaudeamus
Copy link
Contributor Author

Hello, looks like we've added all required data for further review.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now, but can you revert the changes to the package.lock file?

Note: You can avoid automatically changing the package.lock file by using npm ci instead of npm install

@Gaudeamus
Copy link
Contributor Author

ok, done

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 849ae8f into prebid:master Feb 22, 2019
@piotr-yuxuan piotr-yuxuan mentioned this pull request Mar 28, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants