mgidAdapter

[Gaudeamus]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

300x600 banner test

var adUnits = [{
  code: 'div-prebid',
  mediaTypes: {
    banner: {
      sizes: [[300, 600]]
    }
  },
  // Replace this object to test a new Adapter!
  bids: [{
    bidder: 'mgid',
    params : {
      accountId : "219", //test accountId, please replace after test
      placementId : "331749" // 300x600 test placementId, please replace after test
    }
  }]
}];

300x250 banner test

var adUnits = [{
  code: 'div-prebid',
  mediaTypes: {
    banner: {
      sizes: [[300, 250]]
    }
  },
  // Replace this object to test a new Adapter!
  bids: [{
    bidder: 'mgid',
    params : {
      accountId : "219", //test accountId, please replace after test
      placementId : "331748" // 300x250 test placementId, please replace after test
    }
  }]
}];

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
  prebid@mgid.com
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
  add mgid docs prebid.github.io#1161

Other information

[Gaudeamus]

mgid adapter added

[mkendall07]

This pull request introduces 1 alert when merging 19eea57 into 9b08b15 - view on LGTM.com

new alerts:

• 1 for Useless conditional

---

Comment posted by LGTM.com

[Gaudeamus]

huh

[idettman]

The code looks good, the only issue is the comment I posted.

[idettman]

Just making sure, but is this adapter only going to be used in non-GDPR environments? Otherwise, to save user data locally, the consentManagement module needs to be checked for consentString and the vendors list for consent to save data locally. If this isn't going to be used in a GDPR environment, this should be ok.

[Gaudeamus]

added support of gdpr. we'll not return ext.muidn if tracking is not allowed

[Gaudeamus]

@idettman added test params to docs

[Gaudeamus]

Hello, looks like we've added all required data for further review.

[idettman]

LGTM

[idettman]

Code looks good now, but can you revert the changes to the package.lock file?

Note: You can avoid automatically changing the package.lock file by using npm ci instead of npm install

[Gaudeamus]

ok, done

[idettman]

LGTM