Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added setTargeting code for custom key-value pairs to ozone adapter #3494

Closed
wants to merge 4 commits into from
Closed

added setTargeting code for custom key-value pairs to ozone adapter #3494

wants to merge 4 commits into from

Conversation

afsheenb
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Added support for custom key-value pairs in setTargeting;
  • Move customData, lotameData and and ozoneData objects from top-level object into a separate ext.ozone object

@bretg
Copy link
Collaborator

bretg commented Feb 4, 2019

@afsheenb - unit tests please.

@afsheenb
Copy link
Contributor Author

Closing this and resubmitting after a rebase to see if it helps with failing tests.

@afsheenb afsheenb closed this Feb 12, 2019
@afsheenb afsheenb mentioned this pull request Feb 12, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review needs unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afsheenb @bretg