-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidfluence Adapter update - Single call #3347
Conversation
Support single call to server for all bids
Support single call to server for all bids - relative to adapter update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I was testing these changes with the test params in the .md file, I was getting a response back from the server but there was no ad content present.
Below is a copy of the response from the updated endpoint:
{"Bids":[{"BidId":"2dbb3c4341995a","Cpm":0.0,"Width":"300","Height":"250","CreativeId":"","Ad":null}],"UserSyncs":null,"l":""}
When I used the same properties with the previous code/endpoint, I was seeing something return (copied below for reference):
{"BidId":"21bbcddf032d64","Cpm":1E-05,"Width":"300","Height":"250","CreativeId":"","Ad":"<div><a target='_blank' title='Bidfluence' href='http://www.trendworthy.com'><img border='0' src='https://cdn.bidfluence.com/Bdf_300x250.jpg'/></a></div>","UserSyncs":null}
Given the nature of the changes, I wanted to verify the end to end workflow with a test delivery. Do the test params need to be updated to work with the new endpoint? If they should work, can you take a look to see if something is amiss?
@jsnellbaker Thanks |
@francescocristallo Below is a copy of the request payload:
|
@jsnellbaker Thanks, as I thought the new endpoint was blocking the localhost address. I fixed it, now it returns the test Ad correctly. |
Thanks for the update; LGTM |
* Bidfluence Adapter update Support single call to server for all bids * Bidfluence Adapter update Support single call to server for all bids - relative to adapter update
* Bidfluence Adapter update Support single call to server for all bids * Bidfluence Adapter update Support single call to server for all bids - relative to adapter update
* Bidfluence Adapter update Support single call to server for all bids * Bidfluence Adapter update Support single call to server for all bids - relative to adapter update
Type of change
Description of change
Same code refactored for sending a single call to the server instead of multiple calls for each bid