Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidfluence Adapter update - Single call #3347

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

francescocristallo
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Same code refactored for sending a single call to the server instead of multiple calls for each bid

Support single call to server for all bids
Support single call to server for all bids - relative to adapter update
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francescocristallo

While I was testing these changes with the test params in the .md file, I was getting a response back from the server but there was no ad content present.

Below is a copy of the response from the updated endpoint:

{"Bids":[{"BidId":"2dbb3c4341995a","Cpm":0.0,"Width":"300","Height":"250","CreativeId":"","Ad":null}],"UserSyncs":null,"l":""}

When I used the same properties with the previous code/endpoint, I was seeing something return (copied below for reference):

{"BidId":"21bbcddf032d64","Cpm":1E-05,"Width":"300","Height":"250","CreativeId":"","Ad":"<div><a target='_blank' title='Bidfluence' href='http://www.trendworthy.com'><img border='0' src='https://cdn.bidfluence.com/Bdf_300x250.jpg'/></a></div>","UserSyncs":null}

Given the nature of the changes, I wanted to verify the end to end workflow with a test delivery. Do the test params need to be updated to work with the new endpoint? If they should work, can you take a look to see if something is amiss?

@francescocristallo
Copy link
Contributor Author

@jsnellbaker
The params are the same for both endpoints, I created a test page and used the v1 one and it works. Could you please post the call payload? It could be a security restriction blocking the call our side.

Thanks

@jsnellbaker
Copy link
Collaborator

@francescocristallo Below is a copy of the request payload:

{"v":"2.0","azr":true,"ck":true,"re":"http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","st":["http://ap.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true"],"tz":"300","sr":"1680x1050x24","tm":3000,"vp":"1682x348","sdt":"2018/12/05 20:01:47","top":true,"gdpr":false,"gdprc":"","bids":[{"bid":"2e8f27de25bc82","tid":"1000","pid":"1000","rp":0,"w":"300","h":"250"}]}

@francescocristallo
Copy link
Contributor Author

@jsnellbaker Thanks, as I thought the new endpoint was blocking the localhost address. I fixed it, now it returns the test Ad correctly.

@jsnellbaker
Copy link
Collaborator

Thanks for the update; LGTM

@jsnellbaker jsnellbaker merged commit f80f2d5 into prebid:master Dec 7, 2018
loic-talon pushed a commit to onfocusio/Prebid.js that referenced this pull request Dec 19, 2018
* Bidfluence Adapter update

Support single call to server for all bids

* Bidfluence Adapter update

Support single call to server for all bids - relative to adapter update
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Bidfluence Adapter update

Support single call to server for all bids

* Bidfluence Adapter update

Support single call to server for all bids - relative to adapter update
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* Bidfluence Adapter update

Support single call to server for all bids

* Bidfluence Adapter update

Support single call to server for all bids - relative to adapter update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants