Set the OpenRTB device dimensions #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I can't install the dependencies to run it locally due to #3330 :/.... I'll circle back later to fix these once it's resolved, unless someone who's already got them downloaded has cycles to take it over first :) |
jaiminpanchal27
approved these changes
Dec 4, 2018
|
This had a bug in it. This last commit fixed that + added another test for it. |
…late w and h even if the config doesnt have that object.
loic-talon
pushed a commit
to onfocusio/Prebid.js
that referenced
this pull request
Dec 19, 2018
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a comment that was left in Prebid Server: prebid/prebid-server#748 (comment)
OpenRTB has a spot for the device width & height, which are useful for some people.