-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the OpenRTB device dimensions #3336
Conversation
Unfortunately I can't install the dependencies to run it locally due to #3330 :/.... I'll circle back later to fix these once it's resolved, unless someone who's already got them downloaded has cycles to take it over first :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This had a bug in it. This last commit fixed that + added another test for it. |
…late w and h even if the config doesnt have that object.
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
This addresses a comment that was left in Prebid Server: prebid/prebid-server#748 (comment)
OpenRTB has a spot for the device width & height, which are useful for some people.