Adlive bid adapter #3109

mifanich · 2018-09-20T10:10:30Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: 'adlive',
  params: {
    hashes: ['1e100887dd614b0909bf6c49ba7f69fdd1360437']
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
add adlive bid adapter doc prebid.github.io#970

Other information

jsnellbaker

@mifanich Thanks for submitting your adapter.

I took a look over the code and it mostly seems good. There is one area that can be reviewed (see in-line comment below).

However when I tried to test your adapter with the test params on the hello_world page, I wasn't getting anything back from your server.

In the browser, I was seeing two calls going out to your server. One had a Request Method of OPTIONS that just returned a 200 OK response. The other (which seemed to be the POST but wasn't classified as such in the headers) request just canceled.

Can you take a look at this behavior and see why it may not be working? We'd like to see a test ad working with new adapters to ensure the auction workflow is correct.

jsnellbaker · 2018-10-04T13:23:34Z

modules/adliveBidAdapter.js

+    }
+  },
+
+  getUserSyncs: function (syncOptions, serverResponses, gdprConsent) {


If you don't have any userSync pixels you want to fire, you can just remove the entire getUserSyncs property from your adapter. It's not required to define it.

If I do not define this function, tests do not pass.

Can you clarify what tests do not pass? I disabled that part of your adapter code in the branch copy I checked out and rangulp test. There were no unit test errors from what I saw.

@jsnellbaker
I mean circleci tests.

@mifanich I ran the browserstack tests (which is what circleci runs for us automatically) locally with the getUserSyncs code disabled and I didn't see any test failures.

It's possible there was some other issue that happened in the circleci tests you saw that failed that were unrelated to your adapter's code. Can you try to make the change again and push it in this PR so we can retest it?

jsnellbaker · 2018-10-04T15:54:04Z

@mifanich Looks like the circleci test without the userSync code ran fine this time. Please let me know about the delivery/response issue when you get the chance. Thanks!

jsnellbaker · 2018-10-09T12:41:53Z

@mifanich I tried to test the adapter again with the params you updated in the last commit. However I'm still seeing an error when the request is going out.

OPTIONS https://api.publishers.adlive.io/get?pbjs=1 net::ERR_CONNECTION_REFUSED

I have attached screenshots of the request as seen in the Console and Network tabs. Can you take a look?

mifanich · 2018-10-09T17:55:56Z

I have changed test params and improve some logic.
gulp test works fine but circleci tests do not passed.

jsnellbaker · 2018-10-09T18:16:26Z

@mifanich Thanks for the update, I'll check again. The circleci failed for an unrelated reason; I restarted the build and it completed fine.

jsnellbaker · 2018-10-09T18:45:53Z

@mifanich I retested the adapter and I was seeing a response coming back from the server. However the bid wasn't being accepted as per the logic in the interpretResponse function.

The response contained a 1 in the bidResponse.is_passback, which caused the if statement check at https://github.com/prebid/Prebid.js/pull/3109/files#diff-841514cf584a84bb2bb332698c4b54feR46 to fail to pass. Is this expected?

Below is a copy of the response object I saw:

[{"hash":"1e100887dd614b0909bf6c49ba7f69fdd1360437","content":"<script async src=\"//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js\"></script> <!-- lacuisinedebernard_300x250 --> <ins class=\"adsbygoogle\"      style=\"display:inline-block;width:300px;height:250px\"      data-ad-client=\"ca-pub-7357742692072135\"      data-ad-slot=\"9217654942\"></ins> <script> (adsbygoogle = window.adsbygoogle || []).push({}); </script>","size":[300,250],"is_passback":1,"bids":[{"adapter":"pulsepoint","nobid":true},{"adapter":"districtm","nobid":true},{"adapter":"appnexus","nobid":true}]}]

mifanich · 2018-10-10T08:05:23Z

@mifanich I retested the adapter and I was seeing a response coming back from the server. However the bid wasn't being accepted as per the logic in the interpretResponse function.

The response contained a 1 in the bidResponse.is_passback, which caused the if statement check at https://github.com/prebid/Prebid.js/pull/3109/files#diff-841514cf584a84bb2bb332698c4b54feR46 to fail to pass. Is this expected?

Below is a copy of the response object I saw:
[{"hash":"1e100887dd614b0909bf6c49ba7f69fdd1360437","content":"<script async src=\"//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js\"></script>  <ins class=\"adsbygoogle\"      style=\"display:inline-block;width:300px;height:250px\"      data-ad-client=\"ca-pub-7357742692072135\"      data-ad-slot=\"9217654942\"></ins> <script> (adsbygoogle = window.adsbygoogle || []).push({}); </script>","size":[300,250],"is_passback":1,"bids":[{"adapter":"pulsepoint","nobid":true},{"adapter":"districtm","nobid":true},{"adapter":"appnexus","nobid":true}]}]

Yes, you are right! If response contains is_passback=1 it means there is no bids. Need to reload page several times because this is production endpoint. Bids may not present.

mifanich · 2018-10-10T21:15:25Z

@jsnellbaker please check updates

jsnellbaker · 2018-10-15T13:57:32Z

@mifanich Is there some way you can setup a dedicated test? I've been trying to get something to return off/on for a while now and I haven't seen it once return an actual bid.

mifanich · 2018-10-15T14:00:20Z

@jsnellbaker yes, I will do it for 1-2 days

jsnellbaker · 2018-10-15T14:13:40Z

@mifanich Thanks, let me know when it's ready and if I need to use any different params.

mifanich · 2018-10-18T09:45:42Z

@jsnellbaker Fixed.
Please use https://api.publishers.adlive.io/get?pbjs=1&pb_test=1 as POST URL

jsnellbaker · 2018-10-19T13:07:33Z

That test param did work and I saw the test ad; LGTM

* send request to endpoint * tests * improve tests * Add description. Small fix * add maintainer email * restore origin package.json * add getUserSyncs function * remove userSyncs * change endpoint_url params * change test params * change netRevenue to false

Mikhail Ivanchenko and others added 6 commits September 11, 2018 19:04

send request to endpoint

82be81c

tests

4b68d66

improve tests

1b098fa

Add description. Small fix

071d0ba

add maintainer email

391440a

restore origin package.json

c366801

mkendall07 requested a review from mike-chowla September 24, 2018 14:01

mkendall07 assigned mike-chowla Sep 24, 2018

add getUserSyncs function

1b0a2af

jsnellbaker requested review from jsnellbaker and removed request for mike-chowla October 4, 2018 13:07

jsnellbaker assigned jsnellbaker and unassigned mike-chowla Oct 4, 2018

jsnellbaker added the needs review label Oct 4, 2018

jsnellbaker requested changes Oct 4, 2018

View reviewed changes

jsnellbaker added needs update needs unit tests not receiving bids and removed needs review needs unit tests labels Oct 4, 2018

remove userSyncs

305d9d5

change endpoint_url params

aa2a9b8

jsnellbaker removed the needs update label Oct 9, 2018

change test params

0df7202

change netRevenue to false

82c7d3b

jsnellbaker approved these changes Oct 19, 2018

View reviewed changes

jsnellbaker added LGTM and removed not receiving bids labels Oct 19, 2018

jsnellbaker merged commit 6879fea into prebid:master Oct 19, 2018

mifanich deleted the adliveBidAdapter branch October 26, 2018 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adlive bid adapter #3109

Adlive bid adapter #3109

mifanich commented Sep 20, 2018 •

edited

Loading

jsnellbaker left a comment

jsnellbaker Oct 4, 2018

mifanich Oct 4, 2018

jsnellbaker Oct 4, 2018 •

edited

Loading

mifanich Oct 4, 2018

jsnellbaker Oct 4, 2018

jsnellbaker commented Oct 4, 2018

jsnellbaker commented Oct 9, 2018

mifanich commented Oct 9, 2018

jsnellbaker commented Oct 9, 2018

jsnellbaker commented Oct 9, 2018

mifanich commented Oct 10, 2018

mifanich commented Oct 10, 2018

jsnellbaker commented Oct 15, 2018

mifanich commented Oct 15, 2018

jsnellbaker commented Oct 15, 2018

mifanich commented Oct 18, 2018

jsnellbaker commented Oct 19, 2018

Adlive bid adapter #3109

Adlive bid adapter #3109

Conversation

mifanich commented Sep 20, 2018 • edited Loading

Type of change

Description of change

Other information

jsnellbaker left a comment

Choose a reason for hiding this comment

jsnellbaker Oct 4, 2018

Choose a reason for hiding this comment

mifanich Oct 4, 2018

Choose a reason for hiding this comment

jsnellbaker Oct 4, 2018 • edited Loading

Choose a reason for hiding this comment

mifanich Oct 4, 2018

Choose a reason for hiding this comment

jsnellbaker Oct 4, 2018

Choose a reason for hiding this comment

jsnellbaker commented Oct 4, 2018

jsnellbaker commented Oct 9, 2018

mifanich commented Oct 9, 2018

jsnellbaker commented Oct 9, 2018

jsnellbaker commented Oct 9, 2018

mifanich commented Oct 10, 2018

mifanich commented Oct 10, 2018

jsnellbaker commented Oct 15, 2018

mifanich commented Oct 15, 2018

jsnellbaker commented Oct 15, 2018

mifanich commented Oct 18, 2018

jsnellbaker commented Oct 19, 2018

mifanich commented Sep 20, 2018 •

edited

Loading

jsnellbaker Oct 4, 2018 •

edited

Loading