Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsentManagement module - refactor test #2627

Merged
merged 29 commits into from
May 25, 2018
Merged

ConsentManagement module - refactor test #2627

merged 29 commits into from
May 25, 2018

Conversation

anand-venkatraman
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Continuation of the PR #2588 , which fixed a defect on String responses from postMessage to the CMP frame.

One of the tests was breaking with Safari browsers, and hence had to be reverted. This PR fixes the breaking test.

@jsnellbaker

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change
…R-BugFix

# Conflicts:
#	modules/consentManagement.js
#	test/spec/modules/consentManagement_spec.js
@jsnellbaker jsnellbaker self-requested a review May 25, 2018 15:13
@jsnellbaker jsnellbaker self-assigned this May 25, 2018
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 5349894 into prebid:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants