Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner support to Beachfront adapter #2117

Merged
merged 20 commits into from
Mar 6, 2018
Merged

Add banner support to Beachfront adapter #2117

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d6d36b7
Update Beachfront adapter for v1.0
Oct 10, 2017
4c61685
Revert Beachfront test endpoint
Oct 10, 2017
e5f6907
Add Beachfront markdown file
Oct 11, 2017
c3c110b
Add mediaTypes to example
Oct 11, 2017
d8da987
Fix formatting
Oct 11, 2017
8cf7c94
Remove descriptionUrl from bid response
Oct 18, 2017
5f23132
Merge commit '37b218a65bd3cb2903dbd002382a9dc751423622'
Oct 20, 2017
73c5a86
Merge branch 'master' of https://github.com/prebid/Prebid.js
Nov 30, 2017
e003eef
Merge branch 'master' of https://github.com/jsalis/Prebid.js
Nov 30, 2017
9269efb
Merge branch 'master' of https://github.com/jsalis/Prebid.js
Jan 4, 2018
bafa084
Add banner support to Beachfront adapter
Jan 4, 2018
cbeecf3
Fix bid response validation
Jan 24, 2018
62255a0
Update display endpoint
Jan 24, 2018
78ba0dc
Update display request and response to support multiple bids
Feb 7, 2018
cad0bb0
Remove console log
Feb 7, 2018
d3938c8
Added display example to doc
Feb 7, 2018
e6841da
Add support for dnt
Feb 7, 2018
b5116ce
add os version to bid request
Feb 8, 2018
0998ec3
Use size from bid response
Feb 8, 2018
64229fa
Add secure to bid request
Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bid response validation
  • Loading branch information
John Salis committed Jan 24, 2018
commit cbeecf3ccb6960bf83001ffbab244b5732c4d77b
11 changes: 6 additions & 5 deletions modules/beachfrontBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ export const spec = {

interpretResponse(response, { bidRequest }) {
response = response.body;
if (!response || !response.url || !response.bidPrice) {
utils.logWarn(`No valid bids from ${spec.code} bidder`);
return [];
}
let size = getSize(bidRequest.sizes);
let isVideo = bidRequest.mediaTypes && bidRequest.mediaTypes.video;
if (isVideo) {
if (!response || !response.url || !response.bidPrice) {
utils.logWarn(`No valid bids from ${spec.code} bidder`);
return [];
}
return {
requestId: bidRequest.bidId,
bidderCode: spec.code,
Expand Down Expand Up @@ -105,7 +105,8 @@ function createRequestParams(bid) {
},
device: {
ua: global.navigator.userAgent,
devicetype: isMobile() ? 1 : isConnectedTV() ? 3 : 2
devicetype: isMobile() ? 1 : isConnectedTV() ? 3 : 2,
geo: {}
},
cur: ['USD']
};
Expand Down