Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read secure fields to send requests #2078

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Conversation

AntoineJac
Copy link
Contributor

On http page, a video request will then raise an error as the non secure creative will be called from the player which is an https iframe so raise an error.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

On http page, a video request will then raise an error as the non secure creative will be called from the player which is an https iframe so raise an error.
@bretg
Copy link
Collaborator

bretg commented Jan 29, 2018

@AntoineJac - this PR might need to be rebased to pass CI. See #2042

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change. Also you have some linting errors that are failing the build. You can run the linter with the gulp lint command on the command line.

let data = {
page_url: !params.referrer ? utils.getTopWindowUrl() : params.referrer,
page_url: bid.param.secure ? page_rf.replace(/http:/i, "https:") : page_rf,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should anchor this regex to beginning just in-case.

.replace(/^http:/

@AntoineJac
Copy link
Contributor Author

AntoineJac commented Jan 30, 2018 via email

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 017add7 into prebid:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants