Serverbid 1.0 #1802
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,121 +1,75 @@ | ||
| import * as utils from 'src/utils'; | ||
| import { registerBidder } from 'src/adapters/bidderFactory'; | ||
|
|
||
| const BIDDER_CODE = 'serverbid'; | ||
|
|
||
| const CONFIG = { | ||
| 'serverbid': { | ||
| 'BASE_URI': 'https://e.serverbid.com/api/v2' | ||
| }, | ||
| 'connectad': { | ||
| 'BASE_URI': 'https://i.connectad.io/api/v2' | ||
| }, | ||
| 'onefiftytwo': { | ||
| 'BASE_URI': 'https://e.serverbid.com/api/v2' | ||
| }, | ||
| 'insticator': { | ||
| 'BASE_URI': 'https://e.serverbid.com/api/v2' | ||
| } | ||
| }; | ||
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['connectad', 'onefiftytwo', 'insticator'], | ||
|
|
||
| /** | ||
| * Determines whether or not the given bid request is valid. | ||
| * | ||
| * @param {BidRequest} bid The bid params to validate. | ||
| * @return boolean True if this is a valid bid, and false otherwise. | ||
| */ | ||
| isBidRequestValid: function(bid) { | ||
| return !!(bid.params.networkId && bid.params.siteId); | ||
| }, | ||
|
|
||
| /** | ||
| * Make a server request from the list of BidRequests. | ||
| * | ||
| * @param {validBidRequests[]} - an array of bids | ||
| * @return ServerRequest Info describing the request to the server. | ||
| */ | ||
|
|
||
| buildRequests: function(validBidRequests) { | ||
| // Do we need to group by bidder? i.e. to make multiple requests for | ||
| // different endpoints. | ||
|
|
||
| let ret = { | ||
| method: 'POST', | ||
| url: '', | ||
| data: '', | ||
| bidRequest: [] | ||
| }; | ||
|
|
||
| if (validBidRequests.length < 1) { | ||
| return ret; | ||
| } | ||
|
|
||
| let ENDPOINT_URL; | ||
|
|
||
| const data = Object.assign({ | ||
| placements: [], | ||
| time: Date.now(), | ||
| user: {}, | ||
| url: utils.getTopWindowUrl(), | ||
| referrer: document.referrer, | ||
| enableBotFiltering: true, | ||
| includePricingData: true, | ||
| parallel: true | ||
| }, validBidRequests[0].params); | ||
|
|
||
| validBidRequests.map(bid => { | ||
| let config = CONFIG[bid.bidder]; | ||
| ENDPOINT_URL = config.BASE_URI; | ||
|
|
||
| const placement = Object.assign({ | ||
| divName: bid.bidId, | ||
|
|
@@ -125,84 +79,114 @@ ServerBidAdapter = function ServerBidAdapter() { | |
| if (placement.networkId && placement.siteId) { | ||
| data.placements.push(placement); | ||
| } | ||
| }); | ||
|
|
||
| ret.data = JSON.stringify(data); | ||
| ret.bidRequest = validBidRequests; | ||
| ret.url = ENDPOINT_URL; | ||
|
|
||
| return ret; | ||
| }, | ||
|
|
||
| /** | ||
| * Unpack the response from the server into a list of bids. | ||
| * | ||
| * @param {*} serverResponse A successful response from the server. | ||
| * @return {Bid[]} An array of bids which were nested inside the server. | ||
| */ | ||
| interpretResponse: function(serverResponse, bidRequest) { | ||
|
There was a problem hiding this comment. #1748 changed the first argument of {
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}so adding something like serverResponse = serverResponse.body;just below this line, or however you'd prefer to grab the |
||
| let bid; | ||
| let bids; | ||
| let bidId; | ||
| let bidObj; | ||
| let bidResponses = []; | ||
|
|
||
| bids = bidRequest.bidRequest; | ||
|
|
||
| for (let i = 0; i < bids.length; i++) { | ||
| bid = {}; | ||
| bidObj = bids[i]; | ||
| bidId = bidObj.bidId; | ||
| bid.bidderCode = bidObj.bidder; | ||
|
There was a problem hiding this comment.
|
||
|
|
||
| if (serverResponse) { | ||
| const decision = serverResponse.decisions && serverResponse.decisions[bidId]; | ||
| const price = decision && decision.pricing && decision.pricing.clearPrice; | ||
|
|
||
| if (decision && price) { | ||
| bid.requestId = bidId; | ||
| bid.cpm = price; | ||
| bid.width = decision.width; | ||
| bid.height = decision.height; | ||
| bid.ad = retrieveAd(decision); | ||
| bid.currency = 'USD'; | ||
| bid.creativeId = decision.adId; | ||
| bid.ttl = 360; | ||
| bid.netRevenue = true; | ||
| bid.referrer = utils.getTopWindowUrl(); | ||
|
|
||
| bidResponses.push(bid); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return bidResponses; | ||
| }, | ||
|
|
||
| getUserSyncs: function(syncOptions) { | ||
| return []; | ||
| } | ||
| }; | ||
|
|
||
| const sizeMap = [ | ||
| null, | ||
| '120x90', | ||
| '120x90', | ||
| '468x60', | ||
| '728x90', | ||
| '300x250', | ||
| '160x600', | ||
| '120x600', | ||
| '300x100', | ||
| '180x150', | ||
| '336x280', | ||
| '240x400', | ||
| '234x60', | ||
| '88x31', | ||
| '120x60', | ||
| '120x240', | ||
| '125x125', | ||
| '220x250', | ||
| '250x250', | ||
| '250x90', | ||
| '0x0', | ||
| '200x90', | ||
| '300x50', | ||
| '320x50', | ||
| '320x480', | ||
| '185x185', | ||
| '620x45', | ||
| '300x125', | ||
| '800x250' | ||
| ]; | ||
|
|
||
| sizeMap[77] = '970x90'; | ||
| sizeMap[123] = '970x250'; | ||
| sizeMap[43] = '300x600'; | ||
|
|
||
| function getSize(sizes) { | ||
| const result = []; | ||
| sizes.forEach(function(size) { | ||
| const index = sizeMap.indexOf(size[0] + 'x' + size[1]); | ||
| if (index >= 0) { | ||
| result.push(index); | ||
| } | ||
| }); | ||
| return result; | ||
| } | ||
|
|
||
| function retrieveAd(decision) { | ||
| return decision.contents && decision.contents[0] && decision.contents[0].body + utils.createTrackPixelHtml(decision.impressionUrl); | ||
| } | ||
|
|
||
| registerBidder(spec); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # Overview | ||
|
|
||
| Module Name: Serverbid Bid Adapter | ||
|
|
||
| Module Type: Bid Adapter | ||
|
|
||
| Maintainer: jgrimes@serverbid.com | ||
|
|
||
| # Description | ||
|
|
||
| Connects to Serverbid for receiving bids from configured demand sources. | ||
|
|
||
| # Test Parameters | ||
| ```javascript | ||
| var adUnits = [ | ||
| { | ||
| code: 'test-ad-1', | ||
| sizes: [[300, 250]], | ||
| bids: [ | ||
| { | ||
| bidder: 'serverbid', | ||
| params: { | ||
| networkId: '9969', | ||
| siteId: '45678' | ||
|
There was a problem hiding this comment. Are these params still valid for testing bid responses? Currently getting a There was a problem hiding this comment. Ah, those aren't valid. But I just updated this PR with ones that are. |
||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| code: 'test-ad-2', | ||
| sizes: [[300, 250]], | ||
| bids: [ | ||
| { | ||
| bidder: 'serverbid', | ||
| params: { | ||
| networkId: '9969', | ||
| siteId: '45678', | ||
| zoneId: '56789' | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ]; | ||
| ``` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is meant by grouping by bidder, but multiple requests would be required for different endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idettman That answers this question, thanks! We aren't going to make a change for this now since it isn't a scenario that has come up yet, but will add in support for that at some point.