-
Notifications
You must be signed in to change notification settings - Fork 2.3k
DAS Bid Adapter: #14106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DAS Bid Adapter: #14106
Conversation
- Rename ringieraxelspringerBidAdapter to dasBidAdapter - Update module code from 'ringieraxelspringer' to 'das' - Add raspUtils library dependency for native response parsing - Update documentation and test files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
97a9c76 to
8f73bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames and refactors the ringieraxelspringer bid adapter to das (DAS Bidder Adapter). The changes include deleting the old adapter and its tests, adding the new adapter implementation with OpenRTB format support, comprehensive test coverage, and updated documentation.
- Refactored adapter to use OpenRTB protocol instead of custom query string format
- Added support for dynamic GET/POST method selection based on URL length (8k threshold)
- Enhanced native ad support with GDE script integration
- Improved parameter handling and validation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/ringieraxelspringerBidAdapter.js | Deleted old adapter implementation |
| test/spec/modules/ringieraxelspringerBidAdapter_spec.js | Deleted old test file |
| modules/dasBidAdapter.js | New adapter implementation with OpenRTB support and improved architecture |
| test/spec/modules/dasBidAdapter_spec.js | Comprehensive test suite for the new adapter |
| modules/dasBidAdapter.md | Updated documentation with DAS branding and clearer parameter descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
if you pull master you'll get an automated review assignment |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Rename ringieraxelspringerBidAdapter to dasBidAdapter
Update module code from 'ringieraxelspringer' to 'das'
Add raspUtils library dependency for native response parsing
Update documentation and test files
Generate module metadata
contact email of the adapter’s maintainer: monetisation-support@ringieraxelspringer.pl
test parameters for validating bids:
Other information
PR with documentation: prebid/prebid.github.io#6326