Criteo bid adapter: write cookie only on TLD+1 #12323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please title your pr with your adapter |
dzhang-criteo
force-pushed
the
cookie-tld
branch
from
d69e3c1
to
106399d
Compare
dzhang-criteo
changed the title
|
Done! I have added an unit test as well. |
|
Any update on this PR? |
Avoid writing cookies on anything higher than TLD+1 level. e.g. We should write on orange.fr and not on actu.orange.fr
dzhang-criteo
force-pushed
the
cookie-tld
branch
from
106399d
to
950152e
Compare
ChrisHuie
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Avoid writing cookies on anything higher than TLD+1 level.
e.g. We should write on orange.fr and not on actu.orange.fr