Timeout RTD Provider : Module Not Updating bidderTimeout #12274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR resolves the issue where the timeout RTD (Real-Time Data) module was not updating the bidderTimeout value as expected. The module is supposed to modify the bidderTimeout based on predefined rules, but this functionality was not working due to an error in the core RTD module's logic.
The following changes have been made to address the issue:
File Modified: modules/rtdModule/index.js
Fix Description: The argument 'reqBidsConfigObj' passed to the getBidRequestData function has been updated. Previously, the bidderTimeout value was not being updated due to passing the shallow copy of reqBidsConfigObj.
Steps to Reproduce:
Set up the timeout RTD module with rules designed to extend the bidderTimeout.
Observe that the bidderTimeout value does not change as expected.
Existing output : Timeout RTD Issue
We are consoling the bidder Timeout in the above code.
Expected output : Timeout RTD Issue Resolved
We are consoling the bidder Timeout in the above code.
Changes:
Corrected the logic in index.js to ensure the bidderTimeout value is updated appropriately when rules are applied.
Other information