Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid 9: Raise minimum node version from 12 #11528

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Prebid 9: Raise minimum node version from 12 #11528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d6e917
10999 Raise minimum node version from 12 to 16
May 21, 2024
011249e
Attempt bump to node 20 in circleci
dgirardi Jun 3, 2024
77f851b
do not fallback to previous cache
dgirardi Jun 3, 2024
c0226e1
Force cache miss
dgirardi Jun 3, 2024
6e00666
actually force cache miss
dgirardi Jun 3, 2024
2c99092
Merge branch '9.0' into 10999-min-node-ver
dgirardi Jun 3, 2024
7e57066
Merge branch '9.0' into 10999-min-node-ver
dgirardi Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ aliases:
- &environment
docker:
# specify the version you desire here
- image: cimg/node:16.20-browsers
- image: cimg/node:20.14.0-browsers
resource_class: xlarge
# Specify service dependencies here if necessary
# CircleCI maintains a library of pre-built images
Expand All @@ -18,8 +18,6 @@ aliases:
- &restore_dep_cache
keys:
- v1-dependencies-{{ checksum "package.json" }}
# fallback to using the latest cache if no exact match is found
- v1-dependencies-

- &save_dep_cache
paths:
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VARIANT="12"
ARG VARIANT="20"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:${VARIANT}

RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor > /usr/share/keyrings/yarn-archive-keyring.gpg
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
],
"globalVarName": "pbjs",
"defineGlobal": true,
"author": "the prebid.js contributors",
"author": "The prebid.js contributors",
"license": "Apache-2.0",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"@babel/eslint-parser": "^7.16.5",
Expand Down