Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrowthCode Analytics: Updates/BugFixes #10339

Merged
merged 7 commits into from
Aug 14, 2023

Conversation

southern-growthcode
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Update Markdown for growthCodeAnalytics modules
GC-85 Update URL endpoint in the growthCodeAnalytics module
GC-84 added an additional event to send to the server (bidWon)
GC-83 Added the passage of the GCID in the POST to the server
Update growthCodeAnalytics module tests

@Rothalack
Copy link
Collaborator

Can you rollback the changes to package-lock.json? As far as I can tell, they shouldn't be necessary. Let me know if they were intended.

@southern-growthcode
Copy link
Contributor Author

I removed package-lock.json, sorry about that.

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing

@Rothalack Rothalack merged commit a4218f1 into prebid:master Aug 14, 2023
2 checks passed
jxdeveloper1 added a commit to jxdeveloper1/Prebid.js that referenced this pull request Aug 18, 2023
* master: (107 commits)
  Increment version to 8.11.0-pre
  Prebid 8.10.0 release
  add privacyIcon to not native asset list (prebid#10259)
  gppControl_usstates: activity controls for US state consent (prebid#10283)
  UserID: check for all consent (not just GDPR) to check if an ID needs refreshing (prebid#10286)
  fluct Bid Adapter: add user.data to bid requests (prebid#10318)
  Prebid Server adapter: improve cookie_sync tests, check GPP fields are populated (prebid#10362)
  fix: consolidate banner format array (prebid#10365)
  consentManagementGpp: support GPP 1.1 (prebid#10282)
  Relay Bid Adapter : Initial Release (prebid#10197)
  Yieldmo Bid Adapter : adding 4.x VAST protocol support (prebid#10363)
  Cadent Aperture MX Bid Adapter: support GPP and GPP Section Ids (prebid#10342)
  identityLinkSubmodule: add additional check on retrieving the envelope (prebid#10355)
  fluct Bid Adapter: add gpid to bid requests (prebid#10361)
  Increment version to 8.10.0-pre
  Prebid 8.9.0 release
  fledgeForGpt: consolidate publisher configuration (prebid#10360)
  ConcertBidAdapter: Add `browserLanguage` to request `meta` object (prebid#10356)
  GrowthCode Analytics: Updates/BugFixes (prebid#10339)
  Activity Controls GPP: invalidate covered = 0 in mspa (prebid#10354)
  ...
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
* Update Markdown for growthCodeAnalytics modules

* GC-85 Update URL endpoint in growthCodeAnalytics module

* GC-84 added an addition event to send to server

* GC-83 Added the passage of the GCID in the POST

* Update growthCodeAnalytics module tests

* Fixed event bug

* Removed package-lock.json
@southern-growthcode southern-growthcode deleted the analytics_updates branch September 7, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants