Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubiconBidAdapter singleRequest bidder config is not working #9049

Closed
elad-yosifon opened this issue Sep 28, 2022 · 1 comment
Closed

RubiconBidAdapter singleRequest bidder config is not working #9049

elad-yosifon opened this issue Sep 28, 2022 · 1 comment

Comments

@elad-yosifon
Copy link
Contributor

elad-yosifon commented Sep 28, 2022

Type of issue

A bug

Description

RubiconBidAdapter singleRequest config is not working anymore due to caching the "initial" config in a module scope, instead of dynamically using it.

Steps to reproduce

adding this configuration with pbjs.que.push will not be memoized by the rubiconBidAdapter current code:

pbjs.que.push(() => {
  pbjs.setConfig({
    rubicon: {
      singleRequest: true
    }
  });
});

Expected results

setting singleRequest: true should trigger only one request per auction

Actual results

setting singleRequest: true is ignored

Platform details

  • since Prebid.js version 4.10.0

Other information

This is a regression, it used to work before this commit 92e234c.
#5780

elad-yosifon added a commit to elad-yosifon/Prebid.js that referenced this issue Sep 28, 2022
ChrisHuie added a commit that referenced this issue Sep 29, 2022
* fix rubicon singleRequest config regression #9049

* manually kick off testing

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
@dgirardi
Copy link
Collaborator

Closing since #9050 was merged.

JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this issue Feb 9, 2023
* fix rubicon singleRequest config regression prebid#9049

* manually kick off testing

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this issue May 23, 2023
* fix rubicon singleRequest config regression prebid#9049

* manually kick off testing

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants