-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RubiconBidAdapter singleRequest bidder config is not working #9049
Comments
elad-yosifon
added a commit
to elad-yosifon/Prebid.js
that referenced
this issue
Sep 28, 2022
9 tasks
ChrisHuie
added a commit
that referenced
this issue
Sep 29, 2022
* fix rubicon singleRequest config regression #9049 * manually kick off testing Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Closing since #9050 was merged. |
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this issue
Feb 9, 2023
* fix rubicon singleRequest config regression prebid#9049 * manually kick off testing Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this issue
May 23, 2023
* fix rubicon singleRequest config regression prebid#9049 * manually kick off testing Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
A bug
Description
RubiconBidAdapter singleRequest config is not working anymore due to caching the "initial" config in a module scope, instead of dynamically using it.
Steps to reproduce
adding this configuration with
pbjs.que.push
will not be memoized by therubiconBidAdapter
current code:Expected results
setting
singleRequest: true
should trigger only one request per auctionActual results
setting
singleRequest: true
is ignoredPlatform details
Other information
This is a regression, it used to work before this commit 92e234c.
#5780
The text was updated successfully, but these errors were encountered: