Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not set sendStandardTargeting=false when using defaultBidderSettings #715

Closed
derdeka opened this issue Oct 18, 2016 · 1 comment
Closed

Comments

@derdeka
Copy link
Contributor

derdeka commented Oct 18, 2016

When registering defaultBidderSettings from an custom adapter, we can not ommit the standard targeting.

The configuration in the adapter is:

const bidderSettings = {
    alwaysUseBid: true,
    sendStandardTargeting: false,
    suppressEmptyKeys: true,
    adserverTargeting: [
        { key: 'keyXYZ', val: (bidResponse) => bidResponse.keyXYZ }
    ]
};
bidmanager.registerDefaultBidderSetting('adapterXYZ', bidderSettings);

I guess there is a bug in bidmanager@L155:

if (typeof bidderSettings.sendStandardTargeting !== "undefined" && bidder_settings[bidderCode].sendStandardTargeting === false) {

should be

if (typeof bidderSettings.sendStandardTargeting !== "undefined" && bidderSettings.sendStandardTargeting === false) {
snapwich added a commit to rubicon-project/Prebid.js that referenced this issue Oct 18, 2016
@snapwich
Copy link
Collaborator

I had this fix as part of another branch that got put on hold for a bit, I've cherry-picked the relevant commit and will open a pull-request for it now. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants