Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove casale.js for clarity #128

Closed
headertag opened this issue Dec 7, 2015 · 6 comments
Closed

Remove casale.js for clarity #128

headertag opened this issue Dec 7, 2015 · 6 comments
Labels

Comments

@headertag
Copy link

Hello team! Now that indexExchange.js is finalized can you remove casale.js for clarity?

https://github.com/prebid/Prebid.js/blob/master/src/adapters/casale.js

Thanks!

mkendall07 added a commit that referenced this issue Dec 7, 2015
@mkendall07
Copy link
Member

Done, thanks @headertag

@prebid prebid reopened this Dec 7, 2015
@prebid
Copy link
Collaborator

prebid commented Dec 7, 2015

What should be the correct params at:
http://prebid.org/dev-docs/bidders.html#casale-index

@headertag
Copy link
Author

@prebid please advise if the following details are sufficient to update the bidders page.

name: siteID
scope: required
description: the default site if for all slots
example: 123456

name: tier2SiteID
scope: optional
description: the default tier 2 site id for all slots, will create a tier 2 slot for all slots
example: 123457

name: tier3SiteID
scope: optional
description: the default tier 3 site id for all slots, will create a tier 3 slot for all slots
example: 123458

name: sqps
scope: optional
description: sqps object defining the sqps slot information
example: {width: 728, height: 90, siteID: 123456}

bid.params:
These values are in the normal params key, they define per slot values.

name: id
scope: required
description: the slot id
example: '1'

name: siteID
scope: optional
description: The site id for this slot
example: 123456

name: tier2SiteID
scope: optional
description: The tier 2 site id for this slot
example: 123457

name: tier3SiteID
scope:optional
description: The tier 3 site id for this slot
example: 123458

bid:
These values are outside of the params key, at the same level as 'bidder' and 'sizes', they should only be defined on 1 slot, and they are used for every slot on the page.

name: timeout
scope: optional
description: the timeout to be used by index bidder in milliseconds
example: 300

@prebid
Copy link
Collaborator

prebid commented Dec 10, 2015

@mkendall07 the params do not comply to our convention - take a look at the example at https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/pbjs_example_gpt.html

{
       bidder: 'indexExchange',
       siteID: 'TO ADD',
       timeout: 'TO ADD',
       params: {
              id: 'TO ADD',
       }
}

The siteID and timeout and other parameters outside of params should really be inside. Do you mind make that quick update? This is urgent as we do not want to make breaking changes for index's adaptor.

Thanks!

@headertag
Copy link
Author

Fixed in #139

@mkendall07
Copy link
Member

Thanks @headertag for the fix. I've merged now.

@prebid we need to update prebid.org - prebid/prebid.github.io#7

@prebid prebid removed their assignment Jun 8, 2016
vzhukovsky added a commit to aol/Prebid.js that referenced this issue Oct 25, 2017
….30.0 to aolgithub-master

* commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits)
  Added changelog entry.
  Prebid 0.30.1 Release
  Remove undefined variable usage (prebid#1662)
  fixes bug for IE when invalid value passed to parse (prebid#1657)
  Aliasbidder fix (prebid#1652)
  prebidAdapter secure support (prebid#1655)
  Increment pre version
  Prebid 0.30.0 Release
  Add native param support to mediaTypes (prebid#1625)
  PulsePoint Lite adpater changes (prebid#1630)
  Appnexus ast unittest updates (prebid#1654)
  Support aspect ratio specification for native images (prebid#1634)
  Revert changes for switch between client side and server side. (prebid#1653)
  rubicon converted to bidderFactory (prebid#1624)
  Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566)
  Add ignore-loader to handle .md files (prebid#1646)
  fixed PBS cookie syncs (prebid#1637)
  Add placementId request param to Yieldmo bid adapter (prebid#1632)
  Adxcg analytics adapter (prebid#1599)
  Add publisher sub-id support to the Criteo adapter (prebid#1629)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants