-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove casale.js for clarity #128
Comments
Done, thanks @headertag |
What should be the correct params at: |
@prebid please advise if the following details are sufficient to update the bidders page. name: siteID name: tier2SiteID name: tier3SiteID name: sqps bid.params: name: id name: siteID name: tier2SiteID name: tier3SiteID bid: name: timeout |
@mkendall07 the params do not comply to our convention - take a look at the example at https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/pbjs_example_gpt.html
The Thanks! |
Fixed in #139 |
Thanks @headertag for the fix. I've merged now. @prebid we need to update prebid.org - prebid/prebid.github.io#7 |
….30.0 to aolgithub-master * commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits) Added changelog entry. Prebid 0.30.1 Release Remove undefined variable usage (prebid#1662) fixes bug for IE when invalid value passed to parse (prebid#1657) Aliasbidder fix (prebid#1652) prebidAdapter secure support (prebid#1655) Increment pre version Prebid 0.30.0 Release Add native param support to mediaTypes (prebid#1625) PulsePoint Lite adpater changes (prebid#1630) Appnexus ast unittest updates (prebid#1654) Support aspect ratio specification for native images (prebid#1634) Revert changes for switch between client side and server side. (prebid#1653) rubicon converted to bidderFactory (prebid#1624) Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566) Add ignore-loader to handle .md files (prebid#1646) fixed PBS cookie syncs (prebid#1637) Add placementId request param to Yieldmo bid adapter (prebid#1632) Adxcg analytics adapter (prebid#1599) Add publisher sub-id support to the Criteo adapter (prebid#1629) ...
Hello team! Now that indexExchange.js is finalized can you remove casale.js for clarity?
https://github.com/prebid/Prebid.js/blob/master/src/adapters/casale.js
Thanks!
The text was updated successfully, but these errors were encountered: