Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (#10025)" (#…

…10032) This reverts commit 88dbc04.
prebid · Jun 1, 2023 · 4d1f12e · 4d1f12e
1 parent 88dbc04
commit 4d1f12e
Show file tree

Hide file tree

Showing 16 changed files with 37 additions and 503 deletions.
diff --git a/integrationExamples/gpt/growthcode.html b/integrationExamples/gpt/growthcode.html
@@ -7,13 +7,10 @@
   <script async src="../../build/dev/prebid.js"></script>
   <script async src="https://www.googletagservices.com/tag/js/gpt.js"></script>
   <script>
-    var FAILSAFE_TIMEOUT = 33000;
-    var PREBID_TIMEOUT = 10000;
+    var FAILSAFE_TIMEOUT = 3300;
+    var PREBID_TIMEOUT = 1000;
 
     var adUnits = [{
-      debugging: {
-        enabled: true
-      },
       code: 'div-gpt-ad-1460505748561-0',
       mediaTypes: {
         banner: {
@@ -26,11 +23,6 @@
         params: {
           placementId: 13144370
         }
-      },{
-        bidder: 'criteo',
-        params: {
-          zoneId: 497747
-        },
       }],
     }];
 
@@ -75,15 +67,12 @@
       pbjs.setConfig({
         debugging: {
           enabled: true,
-        },
-        realTimeData: {
-          auctionDelay: 1000,
-          dataProviders: [{
-            name: 'growthCodeRtd',
-            waitForIt: true,
-            params: {
-              pid: 'TEST01',
-            }
+          bids: [{
+            bidder: 'appnexus',
+            adUnitCode: '/19968336/header-bid-tag-0',
+            cpm: 1.5,
+            adId: '111111',
+            ad: '<html><body><img src="https://files.prebid.org/creatives/prebid300x250.png"></body></html>'
           }]
         },
         userSync: {
@@ -92,7 +81,7 @@
             storage: {
               type: "html5",
               name: "_sharedID",         // create a cookie with this name
-              expires: 365             // expires in 1 year
+              expires: 365             // expires in 1 years
             }
           },{
             name: 'growthCodeId',

diff --git a/modules/adgenerationBidAdapter.js b/modules/adgenerationBidAdapter.js
@@ -1,8 +1,8 @@
-import {tryAppendQueryString, getBidIdParameter, escapeUnsafeChars, deepAccess} from '../src/utils.js';
+import {tryAppendQueryString, getBidIdParameter, escapeUnsafeChars} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER, NATIVE} from '../src/mediaTypes.js';
 import {config} from '../src/config.js';
-import {convertOrtbRequestToProprietaryNative} from '../src/native.js';
+import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
 
 const ADG_BIDDER_CODE = 'adgeneration';
 
@@ -21,14 +21,14 @@ export const spec = {
   },
   /**
    * Make a server request from the list of BidRequests.
-   * @param validBidRequests
-   * @param bidderRequest
+   *
+   * @param {validBidRequests[]} - an array of bids
    * @return ServerRequest Info describing the request to the server.
    */
   buildRequests: function (validBidRequests, bidderRequest) {
     // convert Native ORTB definition to old-style prebid native definition
     validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests);
-    const ADGENE_PREBID_VERSION = '1.6.0';
+    const ADGENE_PREBID_VERSION = '1.5.0';
     let serverRequests = [];
     for (let i = 0, len = validBidRequests.length; i < len; i++) {
       const validReq = validBidRequests[i];
@@ -38,9 +38,6 @@ export const spec = {
       const criteoId = getCriteoId(validReq);
       const id5id = getId5Id(validReq);
       const id5LinkType = getId5LinkType(validReq);
-      const imuid = deepAccess(validReq, 'userId.imuid');
-      const gpid = deepAccess(validReq, 'ortb2Imp.ext.gpid');
-      const sua = deepAccess(validReq, 'ortb2.device.sua');
       let data = ``;
       data = tryAppendQueryString(data, 'posall', 'SSPLOC');
       const id = getBidIdParameter('id', validReq.params);
@@ -57,12 +54,6 @@ export const spec = {
       data = tryAppendQueryString(data, 'adgext_criteo_id', criteoId);
       data = tryAppendQueryString(data, 'adgext_id5_id', id5id);
       data = tryAppendQueryString(data, 'adgext_id5_id_link_type', id5LinkType);
-      data = tryAppendQueryString(data, 'adgext_imuid', imuid);
-      data = tryAppendQueryString(data, 'adgext_uid2', validReq.userId ? validReq.userId.uid2 : null);
-      data = tryAppendQueryString(data, 'gpid', gpid ? encodeURIComponent(gpid) : null);
-      data = tryAppendQueryString(data, 'uach', sua ? JSON.stringify(sua) : null);
-      data = tryAppendQueryString(data, 'schain', validReq.schain ? encodeURIComponent(JSON.stringify(validReq.schain)) : null);
-
       // native以外にvideo等の対応が入った場合は要修正
       if (!validReq.mediaTypes || !validReq.mediaTypes.native) {
         data = tryAppendQueryString(data, 'imark', '1');

diff --git a/modules/adtelligentBidAdapter.js b/modules/adtelligentBidAdapter.js
@@ -17,6 +17,7 @@ const HOST_GETTERS = {
   }()),
   navelix: () => 'ghb.hb.navelix.com',
   appaloosa: () => 'ghb.hb.appaloosa.media',
+  onefiftytwomedia: () => 'ghb.ads.152media.com',
   bidsxchange: () => 'ghb.hbd.bidsxchange.com',
   streamkey: () => 'ghb.hb.streamkey.net',
   janet: () => 'ghb.bidder.jmgads.com',
@@ -41,6 +42,7 @@ export const spec = {
   code: BIDDER_CODE,
   gvlid: 410,
   aliases: [
+    'onefiftytwomedia',
     'appaloosa',
     'bidsxchange',
     'streamkey',

diff --git a/modules/growthCodeRtdProvider.js b/modules/growthCodeRtdProvider.js
diff --git a/modules/growthCodeRtdProvider.md b/modules/growthCodeRtdProvider.md
diff --git a/modules/ixBidAdapter.js b/modules/ixBidAdapter.js
@@ -145,7 +145,6 @@ export const FEATURE_TOGGLES = {
 let siteID = 0;
 let gdprConsent = '';
 let usPrivacy = '';
-let defaultVideoPlacement = false;
 
 // Possible values for bidResponse.seatBid[].bid[].mtype which indicates the type of the creative markup so that it can properly be associated with the right sub-object of the BidRequest.Imp.
 const MEDIA_TYPES = {
@@ -224,8 +223,7 @@ function bidToVideoImp(bid) {
       if (deepAccess(videoParamRef, 'playerConfig.floatOnScroll')) {
         imp.video.placement = 5;
       } else {
-        imp.video.placement = 3;
-        defaultVideoPlacement = true;
+        imp.video.placement = 4;
       }
     } else {
       logWarn(`IX Bid Adapter: Video context '${context}' is not supported`);
@@ -1114,8 +1112,7 @@ function buildIXDiag(validBidRequests) {
     ren: false,
     version: '$prebid.version$',
     userIds: _getUserIds(validBidRequests[0]),
-    url: window.location.href.split('?')[0],
-    vpd: defaultVideoPlacement
+    url: window.location.href.split('?')[0]
   };
 
   // create ad unit map and collect the required diag properties

diff --git a/modules/sharethroughBidAdapter.js b/modules/sharethroughBidAdapter.js
@@ -93,8 +93,8 @@ export const sharethroughAdapterSpec = {
       if (videoRequest) {
         // default playerSize, only change this if we know width and height are properly defined in the request
         let [w, h] = [640, 360];
-        if (videoRequest.playerSize && videoRequest.playerSize[0] && videoRequest.playerSize[0][0] && videoRequest.playerSize[0][1]) {
-          [w, h] = videoRequest.playerSize[0];
+        if (videoRequest.playerSize && videoRequest.playerSize[0] && videoRequest.playerSize[1]) {
+          [w, h] = videoRequest.playerSize;
         }
 
         impression.video = {

diff --git a/modules/smartadserverBidAdapter.js b/modules/smartadserverBidAdapter.js
@@ -159,11 +159,6 @@ export const spec = {
         sdc: sellerDefinedContext
       };
 
-      const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid', deepAccess(bid, 'ortb2Imp.ext.data.pbadslot', ''));
-      if (gpid) {
-        payload.gpid = gpid;
-      }
-
       if (bidderRequest) {
         if (bidderRequest.gdprConsent) {
           payload.addtl_consent = bidderRequest.gdprConsent.addtlConsent;